From: Trond Myklebust <Trond.Myklebust@netapp.com>
To: "Adamson, Dros" <Weston.Adamson@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Add trace events to the sunrpc subsystem
Date: Mon, 23 Jan 2012 13:22:54 -0800 [thread overview]
Message-ID: <1327353774.2628.13.camel@lade.trondhjem.org> (raw)
In-Reply-To: <7A6A4357-9C97-4402-9A4B-D2E1C2BDF5CF@netapp.com>
On Mon, 2012-01-23 at 12:56 -0800, Adamson, Dros wrote:
> Are you missing a call to tracepoint_synchronize_unregister in the module exit function?
Hi Dros,
The comment section in tracepoint_probe_unregister() appears to imply
that we no longer need to do this:
/**
* tracepoint_probe_unregister - Disconnect a probe from a tracepoint
* @name: tracepoint name
* @probe: probe function pointer
*
* We do not need to call a synchronize_sched to make sure the probes have
* finished running before doing a module unload, because the module unload
* itself uses stop_machine(), which insures that every preempt disabled section
* have finished.
*/
Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
prev parent reply other threads:[~2012-01-23 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 17:49 [PATCH] SUNRPC: Add trace events to the sunrpc subsystem Trond Myklebust
2012-01-23 20:56 ` Adamson, Dros
2012-01-23 21:22 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327353774.2628.13.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=Weston.Adamson@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).