linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Weston Andros Adamson <dros@netapp.com>
To: Trond.Myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org, Weston Andros Adamson <dros@netapp.com>
Subject: [PATCH 1/2] NFS: dont allow minorversion= opt when vers != 4
Date: Wed,  1 Feb 2012 14:00:16 -0500	[thread overview]
Message-ID: <1328122817-661-1-git-send-email-dros@netapp.com> (raw)

Don't allow invalid 'vers' and 'minorversion' combinations in mount options,
such as "vers=3,minorversion=1".

Signed-off-by: Weston Andros Adamson <dros@netapp.com>
---
 fs/nfs/super.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 8e210b2..50baca1 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -1519,6 +1519,9 @@ static int nfs_parse_mount_options(char *raw,
 	if (!sloppy && invalid_option)
 		return 0;
 
+	if (mnt->minorversion && mnt->version != 4)
+		goto out_minorversion_mismatch;
+
 	/*
 	 * verify that any proto=/mountproto= options match the address
 	 * familiies in the addr=/mountaddr= options.
@@ -1552,6 +1555,10 @@ out_invalid_address:
 out_invalid_value:
 	printk(KERN_INFO "NFS: bad mount option value specified: %s\n", p);
 	return 0;
+out_minorversion_mismatch:
+	printk(KERN_INFO "NFS: mount option vers=%d does not support "
+			 "minorversion=%u\n", mnt->version, mnt->minorversion);
+	return 0;
 out_nomem:
 	printk(KERN_INFO "NFS: not enough memory to parse option\n");
 	return 0;
-- 
1.7.4.4


             reply	other threads:[~2012-02-01 19:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01 19:00 Weston Andros Adamson [this message]
2012-02-01 19:00 ` [PATCH 2/2] NFS: add mount option 'v4.1' Weston Andros Adamson
2012-02-01 19:17   ` Chuck Lever
2012-02-01 19:38     ` Adamson, Dros
2012-02-01 19:46     ` Myklebust, Trond
2012-02-01 19:48       ` Chuck Lever
2012-02-01 19:59         ` Myklebust, Trond
2012-02-01 20:05           ` Chuck Lever
2012-02-01 20:25             ` Adamson, Dros
  -- strict thread matches above, loose matches on Subject: below --
2012-02-01 19:06 [PATCH 1/2] NFS: dont allow minorversion= opt when vers != 4 Weston Andros Adamson
2012-02-01 22:44 ` Boaz Harrosh
2012-02-01 23:07   ` Adamson, Dros
2012-02-02 13:51     ` Bryan Schumaker
2012-02-02 17:03       ` Adamson, Dros
2012-02-02 19:00         ` Bryan Schumaker
2012-02-02 20:14           ` Adamson, Dros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328122817-661-1-git-send-email-dros@netapp.com \
    --to=dros@netapp.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).