From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: "Adamson, Andy" <William.Adamson@netapp.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Vitaliy Gusev <gusev.vitaliy@nexenta.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs41: Initialize slot->seq_nr at nfs4_init_slot_table()
Date: Wed, 15 Feb 2012 15:29:53 +0000 [thread overview]
Message-ID: <1329319793.3364.9.camel@lade.trondhjem.org> (raw)
In-Reply-To: <0C12B635-0094-4099-B96C-3637B914A814@netapp.com>
T24gV2VkLCAyMDEyLTAyLTE1IGF0IDE1OjAxICswMDAwLCBBZGFtc29uLCBBbmR5IHdyb3RlOg0K
PiBPbiBGZWIgMTQsIDIwMTIsIGF0IDg6NTAgUE0sIE15a2xlYnVzdCwgVHJvbmQgd3JvdGU6DQo+
IA0KPiA+IE9uIFR1ZSwgMjAxMi0wMi0xNCBhdCAxOTo1MyAtMDUwMCwgSi4gQnJ1Y2UgRmllbGRz
IHdyb3RlOg0KPiA+PiBPbiBXZWQsIEZlYiAxNSwgMjAxMiBhdCAxMjo0MzowOEFNICswMDAwLCBN
eWtsZWJ1c3QsIFRyb25kIHdyb3RlOg0KPiA+Pj4gVGhlbiB3ZSBoYXZlIGEgcHJvYmxlbS4gVGhl
IHplcm8gaW5pdGlhbGlzYXRpb24gaXMgYWxyZWFkeSBpbiB1c2Ugb3V0DQo+ID4+PiB0aGVyZSBp
biBib3RoIGNvbW1lcmNpYWwgYW5kIG5vbi1jb21tZXJjaWFsIHZlcnNpb25zIG9mIExpbnV4LiBJ
dCBpcyB0b28NCj4gPj4+IGxhdGUgdG8gY2hhbmdlIHRoYXQgbm93Lg0KPiA+Pj4gDQo+ID4+PiBG
dXJ0aGVybW9yZSwgc2luY2Ugbm9uZSBvZiB0aGUgc2VydmVycyB3ZSd2ZSB0ZXN0ZWQgYWdhaW5z
dCBpbiBlYXJsaWVyDQo+ID4+PiBCYWtlYXRob25zIGFuZCBDb25uZWN0YXRob25zIGhhdmUgY29t
cGxhaW5lZCwgSSBzdWdnZXN0IHRoYXQgd2UgcmF0aGVyDQo+ID4+PiBjaGFuZ2UgdGhlIHNwZWMg
d2l0aCBhbiBlcnJhdGEuDQo+ID4+IA0KPiA+PiBBcmdoLg0KPiA+PiANCj4gPj4gSSBqdXN0IG5v
dGljZWQgdGhhdCB0aGUgc2VydmVyIHdhcyBjcmFzaGluZyBpbnRlcm1pdHRlbnRseSBhbmQgdHJh
Y2VkIGl0DQo+ID4+IHRvIGluY29ycmVjdCBoYW5kbGluZyBvZiB0aGUgY2FzZSB3aGVyZSB0aGUg
Y2xpZW50IHNlbmRzIGEgb25lLW9wDQo+ID4+IFNFUVVFTkNFIGNvbXBvdW5kIHdpdGggc2VxaWQg
MC4gIEknbSBub3Qgc3VyZSB3aHkgaXQgc3RhcnRlZCBwb3BwaW5nIHVwDQo+ID4+IGp1c3QgaW4g
My4zLS1wZXJoYXBzIHNvbWUgY2hhbmdlIGluIHRoZSB3YXkgdGhlIGNsaWVudCB1c2VzIHNsb3Rz
IG1hZGUNCj4gPj4gdGhhdCBtb3JlIGxpa2VseS4NCj4gPj4gDQo+ID4+IFRoZSBzZXJ2ZXIgY29k
ZSBhY3R1YWxseSBsb29rcyBsaWtlIGl0IGRpZCBhc3N1bWUgaW5pdGlhbCBzZXFpZCAxLCBidXQN
Cj4gPj4gYWNjZXB0ZWQgaW5pdGlhbCBzZXFpZCAwIChleGNlcHQgaW4gdGhpcyBvbmUgY2FzZSkg
YmFzaWNhbGx5IGJ5IG1pc3Rha2UuDQo+ID4+IA0KPiA+PiBJbiBhbnkgY2FzZSwgSSB0aGluayBp
dCBzaG91bGQgYmUgZWFzeSBlbm91Z2ggdG8gdGVhY2ggaXQganVzdCB0byBhY2NlcHQNCj4gPj4g
YW55IHNlcWlkIG9uIGEgcHJldmlvdXNseSB1bnVzZWQgc2xvdCwgc28gSSdsbCBkbyB0aGF0Li4u
Lg0KPiA+IA0KPiA+IEhhbmcgb24uLi4gTG9va2luZyBhdCAzLjIsIEkgdGhpbmsgeW91J3JlIGNv
cnJlY3QuIFdlIHVzZWQgdG8gaW5pdGlhbGlzZQ0KPiA+IHRvIDEsIGFuZCBub3cgd2UncmUgaW5p
dGlhbGlzaW5nIHRvIDAuDQo+IA0KPiBObywgY29tbWl0IGFhY2Q1NTM3MjcwYTc1MmZlMTJhOTkx
NGEyMDcyODRmYzIzNDFjNmQgaW5pdGlhbGl6ZXMgYW5kIHJlc2V0cyB0aGUgc2xvdCB0YWJsZXMg
d2l0aCB0aGUgaXZhbHVlIHdoaWNoIGlzIDEgZm9yIHRoZSBmb3JlY2hhbm5lbCBhbmQgMCBmb3Ig
dGhlIGJhY2sgY2hhbm5lbCwganVzdCBhcyBpbiAzLjIuIA0KPiBUbyBiZSBjbGVhciBmcm9tIGFh
Y2Q1NTM3Og0KPiANCj4gLXN0YXRpYyBpbnQgbmZzNF9pbml0X3Nsb3RfdGFibGVzKHN0cnVjdCBu
ZnM0X3Nlc3Npb24gKnNlc3Npb24pDQo+ICtzdGF0aWMgaW50IG5mczRfc2V0dXBfc2Vzc2lvbl9z
bG90X3RhYmxlcyhzdHJ1Y3QgbmZzNF9zZXNzaW9uICpzZXMpDQo+ICB7DQo+ICAgICAgICAgc3Ry
dWN0IG5mczRfc2xvdF90YWJsZSAqdGJsOw0KPiAtICAgICAgIGludCBzdGF0dXMgPSAwOw0KPiAr
ICAgICAgIGludCBzdGF0dXM7DQo+ICANCj4gLSAgICAgICB0YmwgPSAmc2Vzc2lvbi0+ZmNfc2xv
dF90YWJsZTsNCj4gKyAgICAgICBkcHJpbnRrKCItLT4gJXNcbiIsIF9fZnVuY19fKTsNCj4gKyAg
ICAgICAvKiBGb3JlIGNoYW5uZWwgKi8NCj4gKyAgICAgICB0YmwgPSAmc2VzLT5mY19zbG90X3Rh
YmxlOw0KPiAgICAgICAgIGlmICh0YmwtPnNsb3RzID09IE5VTEwpIHsNCj4gLSAgICAgICAgICAg
ICAgIHN0YXR1cyA9IG5mczRfaW5pdF9zbG90X3RhYmxlKHRibCwNCj4gLSAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICBzZXNzaW9uLT5mY19hdHRycy5tYXhfcmVxcywgMSk7DQo+ICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgXl5eXl5eXg0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGl2YWx1ZSBvZiAx
DQo+IA0KPiArICAgICAgICAgICAgICAgc3RhdHVzID0gbmZzNF9pbml0X3Nsb3RfdGFibGUodGJs
LCBzZXMtPmZjX2F0dHJzLm1heF9yZXFzLCAxKTsNCj4gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeXl5eXg0KPiAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdmFsdWUgb2YgMQ0K
PiArICAgICAgICAgICAgICAgaWYgKHN0YXR1cykgLyogLUVOT01FTSAqLw0KPiArICAgICAgICAg
ICAgICAgICAgICAgICByZXR1cm4gc3RhdHVzOw0KPiArICAgICAgIH0gZWxzZSB7DQo+ICsgICAg
ICAgICAgICAgICBzdGF0dXMgPSBuZnM0X3Jlc2V0X3Nsb3RfdGFibGUodGJsLCBzZXMtPmZjX2F0
dHJzLm1heF9yZXFzLCAxKTsNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICBeXl5eXg0KPiAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpdmFsdWUgb2YgMQ0KPiAgICAgICAgICAg
ICAgICAgaWYgKHN0YXR1cykNCj4gICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHN0YXR1
czsNCj4gICAgICAgICB9DQo+IC0NCj4gLSAgICAgICB0YmwgPSAmc2Vzc2lvbi0+YmNfc2xvdF90
YWJsZTsNCj4gKyAgICAgICAvKiBCYWNrIGNoYW5uZWwgKi8NCj4gKyAgICAgICB0YmwgPSAmc2Vz
LT5iY19zbG90X3RhYmxlOw0KPiAgICAgICAgIGlmICh0YmwtPnNsb3RzID09IE5VTEwpIHsNCj4g
LSAgICAgICAgICAgICAgIHN0YXR1cyA9IG5mczRfaW5pdF9zbG90X3RhYmxlKHRibCwNCj4gLSAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZXNzaW9uLT5iY19hdHRycy5tYXhfcmVxcywg
MCk7DQo+ICsgICAgICAgICAgICAgICBzdGF0dXMgPSBuZnM0X2luaXRfc2xvdF90YWJsZSh0Ymws
IHNlcy0+YmNfYXR0cnMubWF4X3JlcXMsIDApOw0KPiAgICAgICAgICAgICAgICAgaWYgKHN0YXR1
cykNCj4gLSAgICAgICAgICAgICAgICAgICAgICAgbmZzNF9kZXN0cm95X3Nsb3RfdGFibGVzKHNl
c3Npb24pOw0KPiAtICAgICAgIH0NCj4gLQ0KPiArICAgICAgICAgICAgICAgICAgICAgICAvKiBG
b3JlIGFuZCBiYWNrIGNoYW5uZWwgc2hhcmUgYSBjb25uZWN0aW9uIHNvIGdldA0KPiArICAgICAg
ICAgICAgICAgICAgICAgICAgKiBib3RoIHNsb3QgdGFibGVzIG9yIG5laXRoZXIgKi8NCj4gKyAg
ICAgICAgICAgICAgICAgICAgICAgbmZzNF9kZXN0cm95X3Nsb3RfdGFibGVzKHNlcyk7DQo+ICsg
ICAgICAgfSBlbHNlDQo+ICsgICAgICAgICAgICAgICBzdGF0dXMgPSBuZnM0X3Jlc2V0X3Nsb3Rf
dGFibGUodGJsLCBzZXMtPmJjX2F0dHJzLm1heF9yZXFzLCAwKTsNCj4gICAgICAgICByZXR1cm4g
c3RhdHVzOw0KPiAgfQ0KDQpZZXMsIGFuZCBpdCB0aGVuIF9yZW1vdmVkXyB0aGUgcHJldmlvdXNs
eSB1bmNvbmRpdGlvbmFsIGNhbGwgdG8NCm5mczRfcmVzZXRfc2xvdF90YWJsZXMoKSBmcm9tIG5m
czRfcHJvY19jcmVhdGVfc2Vzc2lvbigpLiBXaGljaCBtZWFucw0KdGhhdCB0aGUgdGJsLT5zbG90
cyA9PSBOVUxMIHBhdGggbm8gbG9uZ2VyIGluaXRpYWxpc2VzIHRoZSBzbG90IHRhYmxlDQpzZXF1
ZW5jZSBudW1iZXJzLg0KDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBt
YWludGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20NCnd3dy5uZXRh
cHAuY29tDQoNCg==
next prev parent reply other threads:[~2012-02-15 15:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 21:48 [PATCH] nfs41: Initialize slot->seq_nr at nfs4_init_slot_table() Vitaliy Gusev
2012-02-14 22:46 ` Myklebust, Trond
2012-02-15 0:34 ` Vitaliy Gusev
2012-02-15 0:43 ` Myklebust, Trond
2012-02-15 0:53 ` J. Bruce Fields
2012-02-15 1:50 ` Myklebust, Trond
2012-02-15 2:30 ` Myklebust, Trond
2012-02-15 14:11 ` Vitaliy Gusev
2012-02-15 15:07 ` Adamson, Andy
2012-02-15 15:46 ` Myklebust, Trond
2012-02-15 16:06 ` Andy Adamson
2012-02-15 18:37 ` Myklebust, Trond
2012-02-15 18:45 ` Adamson, Andy
2012-02-15 15:01 ` Adamson, Andy
2012-02-15 15:06 ` Vitaliy Gusev
2012-02-15 15:16 ` Andy Adamson
2012-02-15 15:27 ` Vitaliy Gusev
2012-02-15 15:29 ` Myklebust, Trond [this message]
2012-02-15 15:45 ` Andy Adamson
2012-02-15 15:52 ` J. Bruce Fields
2012-02-15 15:15 ` Andy Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1329319793.3364.9.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=bfields@fieldses.org \
--cc=gusev.vitaliy@nexenta.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).