linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 5/5] 4.0 server tests: remove RD12 (incorrect test)
Date: Wed, 15 Feb 2012 17:45:20 -0500	[thread overview]
Message-ID: <1329345920-16608-6-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1329345920-16608-1-git-send-email-bfields@redhat.com>

From: "J. Bruce Fields" <bfields@redhat.com>

>From 3530 section 8.1.4:

	In the case of WRITE-type operations (i.e., WRITEs and SETATTRs
	which set size), the server must verify that the access mode
	allows writing and return an NFS4ERR_OPENMODE error if it does
	not.  In the case, of READ, the server may perform the
	corresponding check on the access mode, or it may choose to
	allow READ on opens for WRITE only, to accommodate clients whose
	write implementation may unavoidably do reads (e.g., due to
	buffer cache constraints).

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 nfs4.0/servertests/st_read.py |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/nfs4.0/servertests/st_read.py b/nfs4.0/servertests/st_read.py
index 639b436..cce9a03 100644
--- a/nfs4.0/servertests/st_read.py
+++ b/nfs4.0/servertests/st_read.py
@@ -219,17 +219,3 @@ def testOldStateid(t, env):
     fh, stateid = c.confirm(t.code, res)
     res = c.read_file(fh, stateid=oldstateid)
     check(res, NFS4ERR_OLD_STATEID, "READ with old stateid")
-
-def testOpenMode(t, env):
-    """READ with file opened in WRITE mode should return NFS4_OK or NFS4ERR_OPENMODE
-
-    FLAGS: read all
-    DEPEND: MKFILE
-    CODE: RD12
-    """
-    c = env.c1
-    c.init_connection()
-    fh, stateid = c.create_confirm(t.code, access=OPEN4_SHARE_ACCESS_WRITE)
-    res = c.read_file(fh, stateid=stateid)
-    check(res, NFS4ERR_OPENMODE, "READ with file opened in WRITE mode",
-          [NFS4_OK])
-- 
1.7.5.4


  parent reply	other threads:[~2012-02-15 22:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 22:45 pynfs: cleanup and turn off some tests by default J. Bruce Fields
2012-02-15 22:45 ` [PATCH 1/5] 4.0 tests: kill "Starting Call Back server stub" printk J. Bruce Fields
2012-02-15 22:45 ` [PATCH 2/5] 4.0 tests: remove 1-second wait on client creation J. Bruce Fields
2012-02-15 22:45 ` [PATCH 3/5] 4.1 server tests: don't run pnfs tests by default J. Bruce Fields
2012-02-15 22:45 ` [PATCH 4/5] 4.1 server tests: don't run utf8 " J. Bruce Fields
2012-02-15 22:45 ` J. Bruce Fields [this message]
2012-02-16  0:28 ` pynfs: cleanup and turn off some " Boaz Harrosh
2012-02-16  1:28   ` J. Bruce Fields
2012-02-16  3:31     ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1329345920-16608-6-git-send-email-bfields@redhat.com \
    --to=bfields@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).