From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 1/5] 4.1 server tests: rename tests incorrectly using root dir
Date: Fri, 24 Feb 2012 00:00:56 -0500 [thread overview]
Message-ID: <1330059660-2053-2-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1330059660-2053-1-git-send-email-bfields@redhat.com>
From: "J. Bruce Fields" <bfields@redhat.com>
Several of the rename tests were incorrectly creating objects in the
export root.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
nfs4.1/server41tests/st_rename.py | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/nfs4.1/server41tests/st_rename.py b/nfs4.1/server41tests/st_rename.py
index ed5dbb5..f706a1c 100644
--- a/nfs4.1/server41tests/st_rename.py
+++ b/nfs4.1/server41tests/st_rename.py
@@ -185,7 +185,7 @@ def testCfhFile(t, env):
"""
name = env.testname(t)
sess = env.c1.new_client_session(name)
- res = create_obj(sess, [name])
+ res = create_obj(sess, env.c1.homedir + [name])
check(res)
res = rename_obj(sess, env.c1.homedir + [name], env.opts.usefile + [name])
check(res, NFS4ERR_NOTDIR, "RENAME with non-dir <cfh>")
@@ -198,7 +198,7 @@ def testCfhLink(t, env):
"""
name = env.testname(t)
sess = env.c1.new_client_session(name)
- res = create_obj(sess, [name])
+ res = create_obj(sess, env.c1.homedir + [name])
check(res)
res = rename_obj(sess, env.c1.homedir + [name], env.opts.uselink + [name])
check(res, NFS4ERR_NOTDIR, "RENAME with non-dir <cfh>")
@@ -211,7 +211,7 @@ def testCfhBlock(t, env):
"""
name = env.testname(t)
sess = env.c1.new_client_session(name)
- res = create_obj(sess, [name])
+ res = create_obj(sess, env.c1.homedir + [name])
check(res)
res = rename_obj(sess, env.c1.homedir + [name], env.opts.useblock + [name])
check(res, NFS4ERR_NOTDIR, "RENAME with non-dir <cfh>")
@@ -224,7 +224,7 @@ def testCfhChar(t, env):
"""
name = env.testname(t)
sess = env.c1.new_client_session(name)
- res = create_obj(sess, [name])
+ res = create_obj(sess, env.c1.homedir + [name])
check(res)
res = rename_obj(sess, env.c1.homedir + [name], env.opts.usechar + [name])
check(res, NFS4ERR_NOTDIR, "RENAME with non-dir <cfh>")
@@ -237,7 +237,7 @@ def testCfhFifo(t, env):
"""
name = env.testname(t)
sess = env.c1.new_client_session(name)
- res = create_obj(sess, [name])
+ res = create_obj(sess, env.c1.homedir + [name])
check(res)
res = rename_obj(sess, env.c1.homedir + [name], env.opts.usefifo + [name])
check(res, NFS4ERR_NOTDIR, "RENAME with non-dir <cfh>")
@@ -250,7 +250,7 @@ def testCfhSocket(t, env):
"""
name = env.testname(t)
sess = env.c1.new_client_session(name)
- res = create_obj(sess, [name])
+ res = create_obj(sess, env.c1.homedir + [name])
check(res)
res = rename_obj(sess, env.c1.homedir + [name], env.opts.usesocket + [name])
check(res, NFS4ERR_NOTDIR, "RENAME with non-dir <cfh>")
--
1.7.7.6
next prev parent reply other threads:[~2012-02-24 5:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 5:00 pynfs fixes from cthon J. Bruce Fields
2012-02-24 5:00 ` J. Bruce Fields [this message]
2012-02-24 5:00 ` [PATCH 2/5] 4.1 server tests: maketree should not leave files open J. Bruce Fields
2012-02-24 5:00 ` [PATCH 3/5] 4.1 server tests: add citation for COMP4b J. Bruce Fields
2012-02-24 5:00 ` [PATCH 4/5] 4.1 server tests: allow SYMLINK error on rename J. Bruce Fields
2012-02-24 5:01 ` [PATCH 5/5] 4.1 server tests: don't insist on 0-seqid trick in setup J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330059660-2053-2-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).