linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: Jeff Layton <jlayton@redhat.com>, Neil Brown <neilb@suse.de>,
	"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 2/3] mountd: helper function for export upcall's client matching
Date: Fri, 20 Apr 2012 18:46:17 -0400	[thread overview]
Message-ID: <1334961978-2843-3-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1334961978-2843-1-git-send-email-bfields@redhat.com>

From: "J. Bruce Fields" <bfields@redhat.com>

This is just minor cleanup.  It also reorders the tests
slightly--perhaps there was some performance advantage to doing them the
other way, but if so I doubt it's significant.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
 utils/mountd/cache.c |   14 +++++++++-----
 1 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index 0d2f76c..a6bad07 100644
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -495,6 +495,14 @@ static bool match_fsid(struct parsed_fsid *parsed, nfs_export *exp, char *path)
 	return false;
 }
 
+static bool match_client(char *dom, nfs_export *exp, struct addinfo *ai)
+{
+	if (!use_ipaddr && client_member(dom, exp->m_client->m_hostname))
+		return true;
+	if (use_ipaddr && ai && client_check(exp->m_client, ai))
+		return true;
+}
+
 struct addrinfo *lookup_client_addr(char *dom)
 {
 	struct addrinfo *ret;
@@ -583,7 +591,7 @@ static void nfsd_fh(FILE *f)
 				next_exp = exp->m_next;
 			}
 
-			if (!use_ipaddr && !client_member(dom, exp->m_client->m_hostname))
+			if (!match_client(dom, exp, ai))
 				continue;
 			if (exp->m_export.e_mountpoint &&
 			    !is_mountpoint(exp->m_export.e_mountpoint[0]?
@@ -593,10 +601,6 @@ static void nfsd_fh(FILE *f)
 
 			if (!match_fsid(&parsed, exp, path))
 				continue;
-			if (use_ipaddr) {
-				if (ai && !client_check(exp->m_client, ai))
-					continue;
-			}
 			if (!found || subexport(&exp->m_export, found)) {
 				found = &exp->m_export;
 				free(found_path);
-- 
1.7.7.6


  parent reply	other threads:[~2012-04-20 22:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-20 22:46 [PATCH 0/3] Fix use_ipaddr race J. Bruce Fields
2012-04-20 22:46 ` [PATCH 1/3] mountd: unconditionally resolve ip address J. Bruce Fields
2012-04-20 22:46 ` J. Bruce Fields [this message]
2012-04-20 22:46 ` [PATCH 3/3] mountd: ignore use_ipaddr and just try both client types J. Bruce Fields
2012-04-23  1:04 ` [PATCH 0/3] Fix use_ipaddr race NeilBrown
2012-04-28 11:26   ` J. Bruce Fields
2012-04-28 11:28     ` [PATCH 1/3] mountd: parse ip address earlier J. Bruce Fields
2012-04-28 11:28     ` [PATCH 2/3] mountd: add trivial helpers for client-matching J. Bruce Fields
2012-04-28 11:28     ` [PATCH 3/3] mountd: prepend '?' to make use_ipaddr clients self-describing J. Bruce Fields
2012-04-28 11:47     ` [PATCH 0/3] Fix use_ipaddr race NeilBrown
2012-04-28 15:59       ` J. Bruce Fields
2012-05-02  1:41         ` J. Bruce Fields
2012-05-02  1:43           ` [PATCH 1/3] mountd: parse ip address earlier J. Bruce Fields
2012-05-02  1:43           ` [PATCH 2/3] mountd: add trivial helpers for client-matching J. Bruce Fields
2012-05-02  1:43           ` [PATCH 3/3] mountd: prepend '$' to make use_ipaddr clients self-describing J. Bruce Fields
2012-05-02  2:07             ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1334961978-2843-3-git-send-email-bfields@redhat.com \
    --to=bfields@redhat.com \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).