From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Niels de Vos <ndevos@redhat.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"David Howells" <dhowells@redhat.com>,
Jeffrey Layton <jlayton@redhat.com>
Subject: Re: [RFC] Dataloss on NFS-clients who modify an mmap()'d area after closing the file-descriptor
Date: Thu, 3 May 2012 17:26:52 +0000 [thread overview]
Message-ID: <1336066014.5385.41.camel@lade.trondhjem.org> (raw)
In-Reply-To: <4FA2BB68.7070304@redhat.com>
T24gVGh1LCAyMDEyLTA1LTAzIGF0IDE5OjA3ICswMjAwLCBOaWVscyBkZSBWb3Mgd3JvdGU6DQo+
IE9uIDA1LzAzLzIwMTIgMDU6NDMgUE0sIE15a2xlYnVzdCwgVHJvbmQgd3JvdGU6DQo+ICA+IE9u
IFRodSwgMjAxMi0wNS0wMyBhdCAxNzozNCArMDIwMCwgTmllbHMgZGUgVm9zIHdyb3RlOg0KPiAg
Pj4gV2hlbiBhbiBhcHBsaWNhdGlvbiBvbiBhbiBORlMtY2xpZW50ICh0ZXN0ZWQgd2l0aCBORlN2
MykgZXhlY3V0ZXMgdGhlDQo+ICA+PiBmb2xsb3dpbmcgc3RlcHMsIGRhdGEgd3JpdHRlbiBhZnRl
ciB0aGUgY2xvc2UoKSBpcyBuZXZlciBmbHVzaGVkIHRvIHRoZQ0KPiAgPj4gc2VydmVyOg0KPiAg
Pj4NCj4gID4+IDEuIG9wZW4oKQ0KPiAgPj4gMi4gbW1hcCgpDQo+ICA+PiAzLiBjbG9zZSgpDQo+
ICA+PiA0Ljxtb2RpZnkgZGF0YSBpbiB0aGUgbW1hcCdlZCBhcmVhPg0KPiAgPj4gNS4gbXVubWFw
KCkNCj4gID4+DQo+ICA+PiBEcm9wcGluZyB0aGUgY2FjaGVzICh2aWEgL3Byb2Mvc3lzL3ZtL2Ry
b3BfY2FjaGVzKSBvciB1bm1vdW50aW5nIGRvZXMgbm90DQo+ICA+PiByZXN1bHQgaW4gdGhlIGRh
dGEgYmVpbmcgc2VudCB0byB0aGUgc2VydmVyLg0KPiAgPj4NCj4gID4+IFRoZSBtYW4tcGFnZSBm
b3IgbW1hcCAobWFuIDIgbW1hcCkgZG9lcyBtZW50aW9uIHRoYXQgY2xvc2luZyB0aGUgZmlsZS0N
Cj4gID4+IGRlc2NyaXB0b3IgZG9lcyBub3QgbXVubWFwKCkgdGhlIGFyZWEuIFVzaW5nIHRoZSBt
bWFwJ2VkIGFyZWEgYWZ0ZXIgYQ0KPiAgPj4gY2xvc2UoKSBzb3VuZCB2YWxpZCB0byBtZSAoZXZl
biBpZiBpdCBtYXkgYmUgYmFkIHByYWN0aWNlKS4NCj4gID4+DQo+ICA+PiBJbnZlc3RpZ2F0aW9u
IGFuZCBjaGVja2luZyBzaG93ZWQgdGhhdCB0aGUgTkZTLWNsaWVudCBkb2VzIG5vdCBoYW5kbGUN
Cj4gID4+IG11bm1hcCgpLCBhbmQgb25seSBmbHVzaGVzIG9uIGNsb3NlKCkuIFRvIHNvbHZlIHRo
aXMgcHJvYmxlbSwgbGVhc3QgdHdvDQo+ICA+PiBzb2x1dGlvbnMgY2FuIGJlIHByb3Bvc2VkOg0K
PiAgPj4NCj4gID4+IGEuIGZfb3BzLT5yZWxlYXNlKCkgaXMgY2FsbGVkIG9uIG11bm1hcCgpIGFz
IHdlbGwgYXMgb24gY2xvc2UoKSwNCj4gID4+ICAgICAgdGhlcmVmb3JlIHJlbGVhc2UoKSBjYW4g
YmUgdXNlZCB0byBmbHVzaCBkYXRhIGFzIHdlbGwuDQo+ICA+PiBiLiBJbiB0aGUgJ3N0cnVjdCB2
bV9vcGVyYXRpb25zX3N0cnVjdCcgYWRkIGEgLmNsb3NlIHRvIHRoZQ0KPiAgPj4gICAgICAnc3Ry
dWN0IHZtX2FyZWFfc3RydWN0JyBvbiBjYWxsaW5nIG1tYXAoKS9uZnNfZmlsZV9tbWFwKCkgYW5k
IGZsdXNoDQo+ICA+PiAgICAgIHRoZSBkYXRhIGluIHRoZSBuZXcgY2xvc2UoKSBmdW5jdGlvbi4N
Cj4gID4+DQo+ICA+PiBTb2x1dGlvbiBhLiBjb250YWlucyBjdXJyZW50bHkgdmVyeSBmZXcgY29k
ZSBjaGFuZ2VzOg0KPiAgPj4NCj4gID4+IC0tLSBhL2ZzL25mcy9pbm9kZS5jDQo+ICA+PiArKysg
Yi9mcy9uZnMvaW5vZGUuYw0KPiAgPj4gQEAgLTcxMyw2ICs3MTMsOCBAQCBpbnQgbmZzX29wZW4o
c3RydWN0IGlub2RlICppbm9kZSwgc3RydWN0IGZpbGUgKmZpbHApDQo+ICA+Pg0KPiAgPj4gICAg
aW50IG5mc19yZWxlYXNlKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHN0cnVjdCBmaWxlICpmaWxwKQ0K
PiAgPj4gICAgew0KPiAgPj4gKyAgICAgICBpZiAoU19JU1JFRyhpbm9kZS0+aV9tb2RlKSYmICBp
bm9kZS0+aV9tYXBwaW5nLT5ucnBhZ2VzICE9IDApIHsNCj4gID4+ICsgICAgICAgICAgICAgICBu
ZnNfc3luY19tYXBwaW5nKGlub2RlLT5pX21hcHBpbmcpOw0KPiAgPj4gICAgICAgICAgIG5mc19m
aWxlX2NsZWFyX29wZW5fY29udGV4dChmaWxwKTsNCj4gID4+ICAgICAgICAgICByZXR1cm4gMDsN
Cj4gID4+ICAgIH0NCj4gID4+DQo+ICA+PiBUaGUgZGlzYWR2YW50YWdlIGlzLCB0aGF0IG5mc19y
ZWxlYXNlKCkgaXMgY2FsbGVkIG9uIGNsb3NlKCkgdG9vLiBUaGF0DQo+ICA+PiBtZWFucyB0aGlz
IGNhdXNlcyBhIGZsdXNoaW5nIG9mIGRpcnR5IHBhZ2VzLCBhbmQganVzdCBhZnRlciB0aGF0IHRo
ZQ0KPiAgPj4gbmZzX2ZpbGVfY2xlYXJfb3Blbl9jb250ZXh0KCkgbWlnaHQgZmx1c2ggYWdhaW4u
IFRoZSBhZHZhbnRhZ2UgaXMgdGhhdA0KPiAgPj4gaXQgaXMgcG9zc2libGUgKHRob3VnaCBub3Qg
ZG9uZSBhdCB0aGUgbW9tZW50KSB0byByZXR1cm4gYW4gZXJyb3IgaW4NCj4gID4+IGNhc2UgZmx1
c2hpbmcgZmFpbGVkLg0KPiAgPj4NCj4gID4+IFNvbHV0aW9uIGIuIGRvZXMgbm90IHByb3ZpZGUg
YW4gb3B0aW9uIHRvIHJldHVybiBhbiBlcnJvciwgYnV0IGRvZXMgbm90DQo+ICA+PiBnZXQgY2Fs
bGVkIG9uIGVhY2ggY2xvc2UoKToNCj4gID4+DQo+ICA+PiAtLS0gYS9mcy9uZnMvZmlsZS5jDQo+
ICA+PiArKysgYi9mcy9uZnMvZmlsZS5jDQo+ICA+PiBAQCAtNTQ3LDkgKzU0NywxNyBAQCBvdXQ6
DQo+ICA+PiAgICAJcmV0dXJuIHJldDsNCj4gID4+ICAgIH0NCj4gID4+DQo+ICA+PiArc3RhdGlj
IHZvaWQgbmZzX3ZtX2Nsb3NlKHN0cnVjdCB2bV9hcmVhX3N0cnVjdCAqIHZtYSkNCj4gID4+ICt7
DQo+ICA+PiArCXN0cnVjdCBmaWxlICpmaWxwID0gdm1hLT52bV9maWxlOw0KPiAgPj4gKw0KPiAg
Pj4gKwluZnNfZmlsZV9mbHVzaChmaWxwLCAoZmxfb3duZXJfdClmaWxwKTsNCj4gID4+ICt9DQo+
ICA+PiArDQo+ICA+PiAgICBzdGF0aWMgY29uc3Qgc3RydWN0IHZtX29wZXJhdGlvbnNfc3RydWN0
IG5mc19maWxlX3ZtX29wcyA9IHsNCj4gID4+ICAgIAkuZmF1bHQgPSBmaWxlbWFwX2ZhdWx0LA0K
PiAgPj4gICAgCS5wYWdlX21rd3JpdGUgPSBuZnNfdm1fcGFnZV9ta3dyaXRlLA0KPiAgPj4gKwku
Y2xvc2UgPSBuZnNfdm1fY2xvc2UsDQo+ICA+PiAgICB9Ow0KPiAgPj4NCj4gID4+ICAgIHN0YXRp
YyBpbnQgbmZzX25lZWRfc3luY193cml0ZShzdHJ1Y3QgZmlsZSAqZmlscCwgc3RydWN0IGlub2Rl
ICppbm9kZSkNCj4gID4+DQo+ICA+PiBJIHdvdWxkIGxpa2Ugc29tZSBmZWVkYmFjayBvbiB3aGF0
IHNvbHV0aW9uIGlzIG1vc3QgYWNjZXB0YWJsZSwgb3IgYW55DQo+ICA+PiBvdGhlciBzdWdnZXN0
aW9ucy4NCj4gID4NCj4gID4gTmVpdGhlciBzb2x1dGlvbiBpcyBhY2NlcHRhYmxlLiBUaGlzIGlz
bid0IGEgY2xvc2UtdG8tb3BlbiBjYWNoZQ0KPiAgPiBjb25zaXN0ZW5jeSBpc3N1ZS4NCj4gID4N
Cj4gID4gVGhlIHN5bnRheCBvZiBtbWFwKCkgZm9yIGJvdGggYmxvY2sgYW5kIE5GUyBtb3VudHMg
aXMgdGhlIHNhbWU6IHdyaXRlcw0KPiAgPiBhcmUgbm90IGd1YXJhbnRlZWQgdG8gaGl0IHRoZSBk
aXNrIHVudGlsIHlvdXIgYXBwbGljYXRpb24gZXhwbGljaXRseQ0KPiAgPiBjYWxscyBtc3luYygp
Lg0KPiAgPg0KPiANCj4gT2theSwgdGhhdCBtYWtlcyBzZW5zZS4gQnV0IGlmIHRoZSBhcHBsaWNh
dGlvbiBuZXZlciBjYWxscyBtc3luYygpLCBhbmQNCj4ganVzdCBtdW5tYXAoKSdzIHRoZSBhcmVh
LCB3aGVuIHNob3VsZCB0aGUgY2hhbmdlcyBiZSB3cml0dGVuPyBJIGRpZCBub3QNCj4gZXhwZWN0
IHRoYXQgdW5tb3VudGluZyBqdXN0IGRpc3JlZ2FyZHMgdGhlIGRhdGEuDQoNClRoYXQgc3VnZ2Vz
dHMgdGhhdCB0aGUgVk0gaXMgZmFpbGluZyB0byBkaXJ0eSB0aGUgcGFnZXMgb24gbXVubWFwKCkN
CmJlZm9yZSByZWxlYXNpbmcgdGhlIHZtYS0+dm1fZmlsZS4gSWYgc28sIHRoZW4gdGhhdCB3b3Vs
ZCBiZSBhIFZNIGJ1Zy4uLg0KDQotLSANClRyb25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVu
dCBtYWludGFpbmVyDQoNCk5ldEFwcA0KVHJvbmQuTXlrbGVidXN0QG5ldGFwcC5jb20NCnd3dy5u
ZXRhcHAuY29tDQoNCg==
next prev parent reply other threads:[~2012-05-03 17:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 15:34 [RFC] Dataloss on NFS-clients who modify an mmap()'d area after closing the file-descriptor Niels de Vos
2012-05-03 15:43 ` Myklebust, Trond
2012-05-03 17:07 ` Niels de Vos
2012-05-03 17:26 ` Myklebust, Trond [this message]
2012-05-04 16:03 ` Niels de Vos
2012-05-04 18:29 ` Myklebust, Trond
2012-05-07 8:49 ` Niels de Vos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336066014.5385.41.camel@lade.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ndevos@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).