From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx2.netapp.com ([216.240.18.37]:37211 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757041Ab2EGOxa (ORCPT ); Mon, 7 May 2012 10:53:30 -0400 From: "Myklebust, Trond" To: Chuck Lever CC: "linux-nfs@vger.kernel.org" Subject: Re: [PATCH 1/3] NFS: Don't do a full flush to disk on close() if we hold a delegation Date: Mon, 7 May 2012 14:53:29 +0000 Message-ID: <1336402411.9499.1.camel@lade.trondhjem.org> References: <1336399651-6596-1-git-send-email-Trond.Myklebust@netapp.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gTW9uLCAyMDEyLTA1LTA3IGF0IDEwOjQ4IC0wNDAwLCBDaHVjayBMZXZlciB3cm90ZToNCj4g SSB0aG91Z2h0IHRoZSByZWFzb24gd2Ugd2FpdCBmb3IgZmx1c2ggY29tcGxldGlvbiBvbiBjbG9z ZSgpIHdhcyB0byByZXBvcnQgZXJyb3JzLg0KDQpOby4gVGhlIHJlYXNvbiB3aHkgd2Ugd2FpdCBp cyB0byBlbnN1cmUgY2xvc2UtdG8tb3BlbiBjYWNoZSBjb25zaXN0ZW5jeS4NCg0KQ2hlZXJzDQog IFRyb25kDQoNCj4gU2VudCBmcm9tIG15IGlQYWQNCj4gDQo+IE9uIE1heSA3LCAyMDEyLCBhdCAx MDowNyBBTSwgVHJvbmQgTXlrbGVidXN0IDxUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbT4gd3Jv dGU6DQo+IA0KPiA+IElmIHdlIGhvbGQgYSBkZWxlZ2F0aW9uIHRoZW4gd2Uga25vdyB0aGF0IGl0 IHNob3VsZCBiZSBzYWZlIHRvIGNvbnRpbnVlDQo+ID4gdG8gY2FjaGUgdGhlIGRhdGEgYmV5b25k IHRoZSBjbG9zZSgpLiBIb3dldmVyIHNpbmNlIHRoZSBwcm9jZXNzIHRoYXQgd3JvdGUNCj4gPiB0 aGUgZGF0YSBtYXkgZGllIGFmdGVyIGNsb3NlKCksIHdlIG1heSBzdGlsbCB3YW50IHRvIHNlbmQg dGhlIGRhdGEgdG8NCj4gPiBzZXJ2ZXIgYmVmb3JlIHRob3NlIFJQQ1NFQ19HU1MgY3JlZGVudGlh bHMgZXhwaXJlLiBXZSB0aGVyZWZvcmUgY29tcHJvbWlzZQ0KPiA+IGJ5IHN0YXJ0aW5nIHdyaXRl YmFjayB0byB0aGUgc2VydmVyLCBidXQgZG9uJ3Qgd2FpdCBmb3IgY29tcGxldGlvbi4NCj4gPiAN Cj4gPiBTaWduZWQtb2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRh cHAuY29tPg0KPiA+IC0tLQ0KPiA+IGZzL25mcy9maWxlLmMgfCAgICA3ICsrKysrKysNCj4gPiAx IGZpbGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkNCj4gPiANCj4g PiBkaWZmIC0tZ2l0IGEvZnMvbmZzL2ZpbGUuYyBiL2ZzL25mcy9maWxlLmMNCj4gPiBpbmRleCBh YTliNzA5Li44ZWRhOGE2IDEwMDY0NA0KPiA+IC0tLSBhL2ZzL25mcy9maWxlLmMNCj4gPiArKysg Yi9mcy9uZnMvZmlsZS5jDQo+ID4gQEAgLTE3NCw2ICsxNzQsMTMgQEAgbmZzX2ZpbGVfZmx1c2go c3RydWN0IGZpbGUgKmZpbGUsIGZsX293bmVyX3QgaWQpDQo+ID4gICAgaWYgKChmaWxlLT5mX21v ZGUgJiBGTU9ERV9XUklURSkgPT0gMCkNCj4gPiAgICAgICAgcmV0dXJuIDA7DQo+ID4gDQo+ID4g KyAgICAvKg0KPiA+ICsgICAgICogSWYgd2UncmUgaG9sZGluZyBhIHdyaXRlIGRlbGVnYXRpb24s IHRoZW4ganVzdCBzdGFydCB0aGUgaS9vDQo+ID4gKyAgICAgKiBidXQgZG9uJ3Qgd2FpdCBmb3Ig Y29tcGxldGlvbiAob3Igc2VuZCBhIGNvbW1pdCkuDQo+ID4gKyAgICAgKi8NCj4gPiArICAgIGlm IChuZnNfaGF2ZV9kZWxlZ2F0aW9uKGlub2RlLCBGTU9ERV9XUklURSkpDQo+ID4gKyAgICAgICAg cmV0dXJuIGZpbGVtYXBfZmRhdGF3cml0ZShmaWxlLT5mX21hcHBpbmcpOw0KPiA+ICsNCj4gPiAg ICAvKiBGbHVzaCB3cml0ZXMgdG8gdGhlIHNlcnZlciBhbmQgcmV0dXJuIGFueSBlcnJvcnMgKi8N Cj4gPiAgICByZXR1cm4gdmZzX2ZzeW5jKGZpbGUsIDApOw0KPiA+IH0NCj4gPiAtLSANCj4gPiAx LjcuNy42DQo+ID4gDQo+ID4gLS0NCj4gPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDog c2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtbmZzIiBpbg0KPiA+IHRoZSBib2R5IG9m IGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwub3JnDQo+ID4gTW9yZSBtYWpvcmRv bW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sDQoN Ci0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCg0KTmV0 QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFwcC5jb20NCg0K