From: Jeff Layton <jlayton@redhat.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 2/4] nfsd: make test_share a bool return
Date: Fri, 11 May 2012 09:45:12 -0400 [thread overview]
Message-ID: <1336743914-944-3-git-send-email-jlayton@redhat.com> (raw)
In-Reply-To: <1336743914-944-1-git-send-email-jlayton@redhat.com>
All of the callers treat the return that way already.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/nfsd/nfs4state.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 64aeaa0..bb9e00e 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -459,15 +459,15 @@ bmap_to_share_mode(unsigned long bmap) {
return access;
}
-static int
+static bool
test_share(struct nfs4_ol_stateid *stp, struct nfsd4_open *open) {
unsigned int access, deny;
access = bmap_to_share_mode(stp->st_access_bmap);
deny = bmap_to_share_mode(stp->st_deny_bmap);
if ((access & open->op_share_deny) || (deny & open->op_share_access))
- return 0;
- return 1;
+ return false;
+ return true;
}
static int nfs4_access_to_omode(u32 access)
--
1.7.7.6
next prev parent reply other threads:[~2012-05-11 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 13:45 [PATCH 0/4] nfsd: clean up share access with accessor functions Jeff Layton
2012-05-11 13:45 ` [PATCH 1/4] nfsd: consolidate set_access and set_deny Jeff Layton
2012-05-11 13:45 ` Jeff Layton [this message]
2012-05-11 13:45 ` [PATCH 3/4] nfsd: wrap accesses to st_access_bmap Jeff Layton
2012-05-11 13:45 ` [PATCH 4/4] nfsd: wrap all accesses to st_deny_bmap Jeff Layton
2012-05-16 13:55 ` [PATCH 0/4] nfsd: clean up share access with accessor functions J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336743914-944-3-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).