From: "J. Bruce Fields" <bfields@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
"J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 4/6] vfs: don't use PARENT/CHILD lock classes for non-directories
Date: Wed, 30 May 2012 21:50:14 -0400 [thread overview]
Message-ID: <1338429016-20119-5-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1338429016-20119-1-git-send-email-bfields@redhat.com>
From: "J. Bruce Fields" <bfields@redhat.com>
Reserve I_MUTEX_PARENT and I_MUTEX_CHILD for locking of actual
directories.
(Also I_MUTEX_QUOTA isn't really a meaningful name for this locking
class any more; fixed in a later patch.)
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/inode.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index e48a96f..0272ac3 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -978,12 +978,12 @@ void lock_two_nondirectories(struct inode *inode1, struct inode *inode2)
if (inode1 == inode2 || inode2 == NULL)
mutex_lock(&inode1->i_mutex);
else if (inode1 < inode2) {
- mutex_lock_nested(&inode1->i_mutex, I_MUTEX_PARENT);
- mutex_lock_nested(&inode2->i_mutex, I_MUTEX_CHILD);
+ mutex_lock(&inode1->i_mutex);
+ mutex_lock_nested(&inode2->i_mutex, I_MUTEX_QUOTA);
} else {
- mutex_lock_nested(&inode2->i_mutex, I_MUTEX_PARENT);
- mutex_lock_nested(&inode1->i_mutex, I_MUTEX_CHILD);
+ mutex_lock(&inode2->i_mutex);
+ mutex_lock_nested(&inode1->i_mutex, I_MUTEX_QUOTA);
}
}
EXPORT_SYMBOL(lock_two_nondirectories);
--
1.7.9.5
next prev parent reply other threads:[~2012-05-31 1:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 1:50 rename locking J. Bruce Fields
2012-05-31 1:50 ` [PATCH 1/6] gfs2: Get rid of I_MUTEX_QUOTA usage J. Bruce Fields
2012-05-31 7:50 ` Steven Whitehouse
2012-05-31 12:14 ` Bob Peterson
2012-05-31 1:50 ` [PATCH 2/6] vfs: fix outdated i_mutex_lock_class documentation J. Bruce Fields
2012-05-31 18:51 ` Jan Kara
2012-05-31 18:54 ` Jan Kara
2012-05-31 20:11 ` J. Bruce Fields
2012-05-31 20:14 ` [PATCH 6/6 (v2)] vfs: rename I_MUTEX_QUOTA now that it's not used for quotas J. Bruce Fields
2012-05-31 1:50 ` [PATCH 3/6] vfs: pull ext4's double-i_mutex-locking into common code J. Bruce Fields
2012-05-31 1:50 ` J. Bruce Fields [this message]
2012-05-31 1:50 ` [PATCH 5/6] vfs: take i_mutex on renamed file J. Bruce Fields
2012-05-31 1:50 ` [PATCH 6/6] vfs: rename I_MUTEX_QUOTA now that it's not used for quotas J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338429016-20119-5-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).