From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 1/7] nfsd4: remove unnecessary comment
Date: Tue, 10 Jul 2012 12:07:40 -0400 [thread overview]
Message-ID: <1341936466-3821-2-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1341936466-3821-1-git-send-email-bfields@redhat.com>
From: "J. Bruce Fields" <bfields@redhat.com>
For the most part readers of cl_cb_state only need a value that is
"eventually" right. And the value is set only either 1) in response to
some change of state, in which case it's set to UNKNOWN and then a
callback rpc is sent to probe the real state, or b) in the handling of a
response to such a callback. UNKNOWN is therefore always a "temporary"
state, and for the other states we're happy to accept last writer wins.
So I think we're OK here.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/nfsd/nfs4callback.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index a5fd6b9..cbaf4f8 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -756,7 +756,6 @@ static void do_probe_callback(struct nfs4_client *clp)
*/
void nfsd4_probe_callback(struct nfs4_client *clp)
{
- /* XXX: atomicity? Also, should we be using cl_flags? */
clp->cl_cb_state = NFSD4_CB_UNKNOWN;
set_bit(NFSD4_CLIENT_CB_UPDATE, &clp->cl_flags);
do_probe_callback(clp);
--
1.7.9.5
next prev parent reply other threads:[~2012-07-10 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 16:07 [PATCH 0/7] 3.6 nfsd patches J. Bruce Fields
2012-07-10 16:07 ` J. Bruce Fields [this message]
2012-07-10 16:07 ` [PATCH 2/7] nfsd4: nfsd4_lock() cleanup J. Bruce Fields
2012-07-10 16:07 ` [PATCH 3/7] nfsd4: process_open2 cleanup J. Bruce Fields
2012-07-10 16:07 ` [PATCH 4/7] nfsd4: our filesystems are normally case sensitive J. Bruce Fields
2012-07-10 17:34 ` Christoph Hellwig
2012-07-10 19:21 ` J. Bruce Fields
2012-07-10 16:07 ` [PATCH 5/7] nfsd4: release openowners on free in >=4.1 case J. Bruce Fields
2012-07-10 16:07 ` [PATCH 6/7] nfsd: allow owner_override only for regular files J. Bruce Fields
2012-07-10 16:07 ` [PATCH 7/7] nfsd: share some function prototypes J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341936466-3821-2-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox