linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Idan Kedar <idank@tonian.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>, linux-nfs@vger.kernel.org
Cc: Benny Halevy <bhalevy@tonian.com>
Subject: [PATCH 0/3] pnfs: fix a crash when hitting Ctrl+C during LAYOUTGET
Date: Mon, 23 Jul 2012 13:05:04 +0300	[thread overview]
Message-ID: <1343037907-26457-1-git-send-email-idank@tonian.com> (raw)

While working on object layout, we have encountered a general protection fault
in xdr_shrink_bufhead when killing a process performing a lot of reads.

we reproduced it on kernel v3.3 as follows:
* mount an object-based pNFS file system. we used exofs as the MDS. assume the
mount point is /mnt/pnfs
* cp -r /bin /mnt/pnfs
* run:
cd /mnt/pnfs
while while true; do
	echo 3 > /proc/sys/vm/drop_caches; 
	rm -rf bin
	cp -r bin /tmp &
	sleep 1
	kill -s int $!
done
* on my setup it crashed after a couple of minutes, your mileage may vary.

The first patch is the actual fix. the other two are cleanups.

Idan Kedar (3):
  pnfs: defer release of pages in layoutget
  pnfs: nfs4_proc_layoutget returns void
  pnfs: use size_t for LAYOUTGET response pages count

 fs/nfs/nfs4proc.c |   61 ++++++++++++++++++++++++++++++++++++++++++++++++++--
 fs/nfs/pnfs.c     |   39 +---------------------------------
 fs/nfs/pnfs.h     |    2 +-
 3 files changed, 60 insertions(+), 42 deletions(-)

-- 
1.7.6.5


             reply	other threads:[~2012-07-23 10:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-23 10:05 Idan Kedar [this message]
2012-07-23 10:05 ` [PATCH 1/3] pnfs: defer release of pages in layoutget Idan Kedar
2012-07-31 18:54   ` Myklebust, Trond
2012-07-23 10:05 ` [PATCH 2/3] pnfs: nfs4_proc_layoutget returns void Idan Kedar
2012-07-23 10:05 ` [PATCH 3/3] pnfs: use size_t for LAYOUTGET response pages count Idan Kedar
2012-07-31 18:55   ` Myklebust, Trond
2012-07-24  8:21 ` [PATCH 0/3] pnfs: fix a crash when hitting Ctrl+C during LAYOUTGET Idan Kedar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343037907-26457-1-git-send-email-idank@tonian.com \
    --to=idank@tonian.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bhalevy@tonian.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).