From: Idan Kedar <idank@tonian.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>, linux-nfs@vger.kernel.org
Cc: Benny Halevy <bhalevy@tonian.com>
Subject: [PATCH 3/3] pnfs: use size_t for LAYOUTGET response pages count
Date: Mon, 23 Jul 2012 13:05:07 +0300 [thread overview]
Message-ID: <1343037907-26457-4-git-send-email-idank@tonian.com> (raw)
In-Reply-To: <1343037907-26457-1-git-send-email-idank@tonian.com>
Signed-off-by: Idan Kedar <idank@tonian.com>
Signed-off-by: Benny Halevy <bhalevy@tonian.com>
---
fs/nfs/nfs4proc.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 3db9ce7..056c3f0 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -6164,13 +6164,13 @@ static void nfs4_layoutget_done(struct rpc_task *task, void *calldata)
dprintk("<-- %s\n", __func__);
}
-static u32 max_response_pages(struct nfs_server *server)
+static size_t max_response_pages(struct nfs_server *server)
{
u32 max_resp_sz = server->nfs_client->cl_session->fc_attrs.max_resp_sz;
return nfs_page_array_len(0, max_resp_sz);
}
-static void free_pagevec(struct page **pages, u32 size)
+static void free_pagevec(struct page **pages, size_t size)
{
int i;
@@ -6185,7 +6185,7 @@ static void free_pagevec(struct page **pages, u32 size)
kfree(pages);
}
-static struct page **alloc_pagevec(u32 size, gfp_t gfp_flags)
+static struct page **alloc_pagevec(size_t size, gfp_t gfp_flags)
{
struct page **pages;
int i;
@@ -6212,7 +6212,7 @@ static void nfs4_layoutget_release(void *calldata)
{
struct nfs4_layoutget *lgp = calldata;
struct nfs_server *server = NFS_SERVER(lgp->args.inode);
- u32 max_pages = max_response_pages(server);
+ size_t max_pages = max_response_pages(server);
dprintk("--> %s\n", __func__);
free_pagevec(lgp->args.layout.pages, max_pages);
@@ -6230,7 +6230,7 @@ static const struct rpc_call_ops nfs4_layoutget_call_ops = {
void nfs4_proc_layoutget(struct nfs4_layoutget *lgp, gfp_t gfp_flags)
{
struct nfs_server *server = NFS_SERVER(lgp->args.inode);
- u32 max_pages = max_response_pages(server);
+ size_t max_pages = max_response_pages(server);
struct rpc_task *task;
struct rpc_message msg = {
.rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_LAYOUTGET],
--
1.7.6.5
next prev parent reply other threads:[~2012-07-23 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 10:05 [PATCH 0/3] pnfs: fix a crash when hitting Ctrl+C during LAYOUTGET Idan Kedar
2012-07-23 10:05 ` [PATCH 1/3] pnfs: defer release of pages in layoutget Idan Kedar
2012-07-31 18:54 ` Myklebust, Trond
2012-07-23 10:05 ` [PATCH 2/3] pnfs: nfs4_proc_layoutget returns void Idan Kedar
2012-07-23 10:05 ` Idan Kedar [this message]
2012-07-31 18:55 ` [PATCH 3/3] pnfs: use size_t for LAYOUTGET response pages count Myklebust, Trond
2012-07-24 8:21 ` [PATCH 0/3] pnfs: fix a crash when hitting Ctrl+C during LAYOUTGET Idan Kedar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343037907-26457-4-git-send-email-idank@tonian.com \
--to=idank@tonian.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bhalevy@tonian.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).