From: "J. Bruce Fields" <bfields@redhat.com>
To: Steve Dickson <SteveD@redhat.com>
Cc: Jim Rees <rees@umich.edu>,
linux-nfs@vger.kernel.org, "J. Bruce Fields" <bfields@redhat.com>
Subject: [PATCH 2/4] rpc.gssd: don't call printerr from signal handler
Date: Tue, 31 Jul 2012 17:00:47 -0400 [thread overview]
Message-ID: <1343768449-32205-2-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <20120731205931.GA32161@fieldses.org>
From: "J. Bruce Fields" <bfields@redhat.com>
printerr() isn't actually safe to call from a signal handler. It might
be possible to make it so, but I think this is the only case in
nfs-utils where we try to, and I'm not convince it's worth it.
This fixes a bug that would eventually cause mounts to hang when gssd
is run with -vv.
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
utils/gssd/gssd_main_loop.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/utils/gssd/gssd_main_loop.c b/utils/gssd/gssd_main_loop.c
index 9954ffb..6914687 100644
--- a/utils/gssd/gssd_main_loop.c
+++ b/utils/gssd/gssd_main_loop.c
@@ -61,10 +61,8 @@ extern int pollsize;
static volatile int dir_changed = 1;
-static void dir_notify_handler(int sig)
+static void dir_notify_handler(__attribute__((unused))int sig)
{
- printerr(2, "dir_notify_handler: sig %d\n", sig);
-
dir_changed = 1;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-07-31 21:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-27 21:02 [PATCH] rpc.gssd: don't call poll() twice a second J. Bruce Fields
2012-07-27 23:08 ` Jim Rees
2012-07-29 17:48 ` J. Bruce Fields
2012-07-29 23:09 ` Steve Dickson
2012-07-30 20:59 ` J. Bruce Fields
2012-07-30 22:10 ` J. Bruce Fields
2012-07-31 16:50 ` Steve Dickson
2012-07-31 20:59 ` J. Bruce Fields
2012-07-31 21:00 ` [PATCH 1/4] rpc.gssd: simplify signal handling J. Bruce Fields
2012-08-06 14:22 ` Steve Dickson
2012-07-31 21:00 ` J. Bruce Fields [this message]
2012-07-31 21:22 ` [PATCH 2/4] rpc.gssd: don't call printerr from signal handler Chuck Lever
2012-08-06 14:22 ` Steve Dickson
2012-07-31 21:00 ` [PATCH 3/4] rpc.gssd: handle error to open toplevel directory J. Bruce Fields
2012-08-06 14:23 ` Steve Dickson
2012-07-31 21:00 ` [PATCH 4/4] rpc.gssd: don't call poll() twice a second J. Bruce Fields
2012-07-31 21:23 ` Chuck Lever
2012-07-31 21:27 ` J. Bruce Fields
2012-07-31 22:29 ` Chuck Lever
2012-08-01 12:35 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343768449-32205-2-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).