linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mantas Mikulėnas" <grawity@gmail.com>
To: linux-nfs@vger.kernel.org
Cc: "Mantas Mikulėnas" <grawity@gmail.com>
Subject: [PATCH] utils: Return status 0 on clean exits
Date: Sat,  6 Oct 2012 02:14:26 +0300	[thread overview]
Message-ID: <1349478866-680992-1-git-send-email-grawity@gmail.com> (raw)

Some init systems actually expect daemons to return 0 on success.
---
 utils/gssd/gssd.c     | 2 +-
 utils/gssd/svcgssd.c  | 2 +-
 utils/mountd/mountd.c | 3 ++-
 utils/statd/statd.c   | 3 ++-
 4 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/utils/gssd/gssd.c b/utils/gssd/gssd.c
index 7825255..a3292c9 100644
--- a/utils/gssd/gssd.c
+++ b/utils/gssd/gssd.c
@@ -71,7 +71,7 @@ sig_die(int signal)
 	if (root_uses_machine_creds)
 		gssd_destroy_krb5_machine_creds();
 	printerr(1, "exiting on signal %d\n", signal);
-	exit(1);
+	exit(0);
 }
 
 void
diff --git a/utils/gssd/svcgssd.c b/utils/gssd/svcgssd.c
index 1afff9e..8aee3b2 100644
--- a/utils/gssd/svcgssd.c
+++ b/utils/gssd/svcgssd.c
@@ -153,7 +153,7 @@ sig_die(int signal)
 {
 	/* destroy krb5 machine creds */
 	printerr(1, "exiting on signal %d\n", signal);
-	exit(1);
+	exit(0);
 }
 
 void
diff --git a/utils/mountd/mountd.c b/utils/mountd/mountd.c
index bcf5080..993b6e6 100644
--- a/utils/mountd/mountd.c
+++ b/utils/mountd/mountd.c
@@ -196,7 +196,8 @@ killer (int sig)
 		wait_for_workers();
 	}
 	cleanup_lockfiles();
-	xlog (L_FATAL, "Caught signal %d, un-registering and exiting.", sig);
+	xlog (L_NOTICE, "Caught signal %d, un-registering and exiting.", sig);
+	exit(0);
 }
 
 static void
diff --git a/utils/statd/statd.c b/utils/statd/statd.c
index 01fdb41..652546c 100644
--- a/utils/statd/statd.c
+++ b/utils/statd/statd.c
@@ -99,7 +99,8 @@ static void
 killer (int sig)
 {
 	statd_unregister ();
-	xlog_err ("Caught signal %d, un-registering and exiting", sig);
+	xlog(D_GENERAL, "Caught signal %d, un-registering and exiting", sig);
+	exit(0);
 }
 
 static void
-- 
1.7.12.2


             reply	other threads:[~2012-10-05 23:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-05 23:14 Mantas Mikulėnas [this message]
2012-10-15 20:14 ` [PATCH] utils: Return status 0 on clean exits Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349478866-680992-1-git-send-email-grawity@gmail.com \
    --to=grawity@gmail.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).