From: Weston Andros Adamson <dros@netapp.com>
To: Trond.Myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org, Weston Andros Adamson <dros@netapp.com>
Subject: [PATCH 03/25] SUNRPC: remove BUG_ON from rpc_run_bc_task
Date: Tue, 23 Oct 2012 10:43:27 -0400 [thread overview]
Message-ID: <1351003429-18887-4-git-send-email-dros@netapp.com> (raw)
In-Reply-To: <1351003429-18887-1-git-send-email-dros@netapp.com>
Replace BUG_ON() with WARN_ON_ONCE() - rpc_run_bc_task calls rpc_init_task()
then increments the tk_count, so this is a simple sanity check that
if hit once would hit every time this code path is executed.
Signed-off-by: Weston Andros Adamson <dros@netapp.com>
---
net/sunrpc/clnt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
index eacdb15..fe8a133 100644
--- a/net/sunrpc/clnt.c
+++ b/net/sunrpc/clnt.c
@@ -915,7 +915,7 @@ struct rpc_task *rpc_run_bc_task(struct rpc_rqst *req,
task->tk_action = call_bc_transmit;
atomic_inc(&task->tk_count);
- BUG_ON(atomic_read(&task->tk_count) != 2);
+ WARN_ON_ONCE(atomic_read(&task->tk_count) != 2);
rpc_execute(task);
out:
--
1.7.9.6 (Apple Git-31.1)
next prev parent reply other threads:[~2012-10-23 14:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 14:43 [PATCH 00/25] SUNRPC: remove many BUG_ONs Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 01/25] SUNRPC: remove BUG_ON in __rpc_clnt_handle_event Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 02/25] SUNRPC: remove BUG_ON from rpc_bind_new_program Weston Andros Adamson
2012-10-23 14:43 ` Weston Andros Adamson [this message]
2012-10-23 14:43 ` [PATCH 04/25] SUNRPC: remove BUG_ON from call_transmit Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 05/25] SUNRPC: remove BUG_ON from rpc_call_sync Weston Andros Adamson
2012-11-01 15:56 ` Myklebust, Trond
2012-10-23 14:43 ` [PATCH 06/25] SUNRPC: remove BUG_ON from call_bc_transmit Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 07/25] " Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 08/25] SUNRPC: remove BUG_ON from rpc_sleep_on* Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 09/25] SUNRPC: remove two BUG_ON asserts Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 10/25] SUNRPC: remove BUG_ON from xprt_destroy_backchannel Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 11/25] SUNRPC: remove BUG_ON from bc_send Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 12/25] SUNRPC: remove BUG_ON calls from cache_read Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 13/25] SUNRPC: remove BUG_ON in rpc_put_sb_net Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 14/25] SUNRPC: remove BUG_ON from svc_pool_map_set_cpumask Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 15/25] SUNRPC: remove BUG_ONs from *_reclassify_socket* Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 16/25] SUNRPC: remove BUG_ON in svc_xprt_received Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 17/25] SUNRPC: remove BUG_ONs checking RPCSVC_MAXPAGES Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 18/25] SUNRPC: remove BUG_ON in xdr_shrink_bufhead Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 19/25] SUNRPC: remove BUG_ON from bc_malloc Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 20/25] SUNRPC: remove BUG_ON from encode_rpcb_string Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 21/25] SUNRPC: remove BUG_ON in svc_register Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 22/25] SUNRPC: remove BUG_ON from __rpc_sleep_on_priority Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 23/25] SUNRPC: remove BUG_ONs checking RPC_IS_QUEUED Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 24/25] SUNRPC: remove BUG_ON in svc_delete_xprt Weston Andros Adamson
2012-10-23 14:43 ` [PATCH 25/25] SUNRPC: remove BUG_ON in rpc_release_task Weston Andros Adamson
-- strict thread matches above, loose matches on Subject: below --
2012-10-16 16:30 [PATCH 01/25] SUNRPC: remove BUG_ON in __rpc_clnt_handle_event Weston Andros Adamson
2012-10-16 16:30 ` [PATCH 03/25] SUNRPC: remove BUG_ON() from rpc_run_bc_task Weston Andros Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351003429-18887-4-git-send-email-dros@netapp.com \
--to=dros@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).