From: "J. Bruce Fields" <bfields@redhat.com>
To: linux-nfs@vger.kernel.org
Cc: "J. Bruce Fields" <bfields@redhat.com>, stable@vger.kernel.org
Subject: [PATCH 1/8] nfsd: fix v4 reply caching
Date: Mon, 26 Nov 2012 09:39:52 -0500 [thread overview]
Message-ID: <1353940799-11763-2-git-send-email-bfields@redhat.com> (raw)
In-Reply-To: <1353940799-11763-1-git-send-email-bfields@redhat.com>
From: "J. Bruce Fields" <bfields@redhat.com>
Very embarassing: 1091006c5eb15cba56785bd5b498a8d0b9546903 "nfsd: turn
on reply cache for NFSv4" missed a line, effectively leaving the reply
cache off in the v4 case. I thought I'd tested that, but I guess not.
This time, wrote a pynfs test to confirm it works.
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---
fs/nfsd/nfssvc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 2013aa00..30d3784 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -640,7 +640,7 @@ nfsd_dispatch(struct svc_rqst *rqstp, __be32 *statp)
}
/* Store reply in cache. */
- nfsd_cache_update(rqstp, proc->pc_cachetype, statp + 1);
+ nfsd_cache_update(rqstp, rqstp->rq_cachetype, statp + 1);
return 1;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-11-26 14:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 14:39 fixes for 3.8 J. Bruce Fields
2012-11-26 14:39 ` J. Bruce Fields [this message]
2012-11-26 14:39 ` [PATCH 2/8] nfsd4: no, we're not going to check tags for utf8 J. Bruce Fields
2012-11-26 14:39 ` [PATCH 3/8] nfsd4: simplify reading of opnum J. Bruce Fields
2012-11-26 14:39 ` [PATCH 4/8] nfsd4: reorganize write decoding J. Bruce Fields
2012-11-26 14:39 ` [PATCH 5/8] nfsd4: move more write parameters into xdr argument J. Bruce Fields
2012-11-26 14:39 ` [PATCH 6/8] nfsd4: delay filling in write iovec array till after xdr decoding J. Bruce Fields
2012-11-26 14:39 ` [PATCH 7/8] nfsd4: downgrade some fs/nfsd/nfs4state.c BUG's J. Bruce Fields
2012-11-26 14:39 ` [PATCH 8/8] nfsd4: return badname on use "." or "..", or "/" J. Bruce Fields
2012-11-26 15:47 ` fixes for 3.8 J. Bruce Fields
2012-11-26 16:24 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353940799-11763-2-git-send-email-bfields@redhat.com \
--to=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).