From: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
To: Stef Bon <stefbon@gmail.com>
Cc: Steve French <smfrench@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
linux-cifs <linux-cifs@vger.kernel.org>
Subject: Re: Possible to make nfs aware of a inotify watch has been set.
Date: Fri, 30 Nov 2012 14:37:20 +0100 [thread overview]
Message-ID: <1354282642.22426.7.camel@thorin> (raw)
In-Reply-To: <CANXojcwRy5cBz=E1S567J-1BFC4AiamLr=35bKrX0Zq-Me2b3w@mail.gmail.com>
Hi!
Since you introduced the "user experience" ignoring the fact that each
user is quite different - especially if it comes to the "Average Joes
using Ubuntu vs techies" department -, you should be prepared to eat
your own dog food:
On Fre, 2012-11-30 at 08:10 +0100, Stef Bon wrote:
[...]
> At this moment the different events look like:
Perhaps you should have used hexadecimal notation so that it is easier
for the usual/average users of source code to see the bits more easily.
In short: Please improve the user experience. Thank you.
> #define NOTIFYFS_FSEVENT_META_ATTRIB_NOTSET 2
> #define NOTIFYFS_FSEVENT_META_ATTRIB_MODE 4
> #define NOTIFYFS_FSEVENT_META_ATTRIB_OWNER 8
> #define NOTIFYFS_FSEVENT_META_ATTRIB_GROUP 16
> #define NOTIFYFS_FSEVENT_META_ATTRIB 28
And that number seems pretty random - not a power of 2 or a bit mask or
the sum of the above.
> #define NOTIFYFS_FSEVENT_META_XATTR_NOTSET 32
> #define NOTIFYFS_FSEVENT_META_XATTR_CREATE 64
> #define NOTIFYFS_FSEVENT_META_XATTR_MODIFY 128
> #define NOTIFYFS_FSEVENT_META_XATTR_DELETE 256
> #define NOTIFYFS_FSEVENT_META_XATTR 448
And that number seems pretty random too - not a power of 2 or a bit mask
or the sum of the above.
> #define NOTIFYFS_FSEVENT_FILE_NOTSET 512
> #define NOTIFYFS_FSEVENT_FILE_MODIFIED 1024
> #define NOTIFYFS_FSEVENT_FILE_SIZE 2048
> #define NOTIFYFS_FSEVENT_FILE_OPEN 4096
> #define NOTIFYFS_FSEVENT_FILE_READ 8192
> #define NOTIFYFS_FSEVENT_FILE_CLOSE_WRITE 16384
> #define NOTIFYFS_FSEVENT_FILE_CLOSE_NOWRITE 32768
> #define NOTIFYFS_FSEVENT_MOVE_NOTSET 65536
And from here own I'm too lazy to calculate (or even guess) if these are
actually powers of 2 or not.
> #define NOTIFYFS_FSEVENT_MOVE_CREATED 131072
> #define NOTIFYFS_FSEVENT_MOVE_MOVED 262144
> #define NOTIFYFS_FSEVENT_MOVE_MOVED_FROM 524288
> #define NOTIFYFS_FSEVENT_MOVE_MOVED_TO 1048576
> #define NOTIFYFS_FSEVENT_MOVE_DELETED 2097152
>
> #define NOTIFYFS_FSEVENT_FS_NOTSET 4194304
> #define NOTIFYFS_FSEVENT_FS_MOUNT 8388608
> #define NOTIFYFS_FSEVENT_FS_UNMOUNT 16777216
> #define NOTIFYFS_FSEVENT_FS_NLINKS 33554432
MfG,
Bernd
--
Bernd Petrovitsch Email : bernd@petrovitsch.priv.at
LUGA : http://www.luga.at
prev parent reply other threads:[~2012-11-30 14:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 9:32 Possible to make nfs aware of a inotify watch has been set Stef Bon
2012-11-29 14:03 ` Myklebust, Trond
2012-11-29 14:49 ` Stef Bon
2012-11-29 14:54 ` Myklebust, Trond
2012-11-29 15:22 ` simo
2012-11-29 15:33 ` Myklebust, Trond
2012-11-29 16:28 ` Steve French
2012-11-29 17:05 ` Myklebust, Trond
2012-11-29 16:39 ` Stef Bon
2012-11-29 17:11 ` Myklebust, Trond
2012-11-29 20:05 ` simo
2012-11-29 21:09 ` Myklebust, Trond
2012-11-29 22:26 ` simo
2012-11-29 20:10 ` Stef Bon
2012-11-29 20:20 ` Al Viro
2012-11-29 20:31 ` Stef Bon
2012-11-29 21:16 ` Al Viro
2012-11-29 23:14 ` Stef Bon
2012-11-29 23:44 ` Steve French
2012-11-30 7:10 ` Stef Bon
2012-11-30 7:19 ` Stef Bon
2012-11-30 13:37 ` Bernd Petrovitsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354282642.22426.7.camel@thorin \
--to=bernd@petrovitsch.priv.at \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=stefbon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).