From: Joe Perches <joe@perches.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
"David S. Miller" <davem@davemloft.net>,
linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Tom Tucker <tom@ogc.us>,
steved@redhat.com, Tom Talpey <ttalpey@microsoft.com>
Subject: Re: [PATCH] sunrpc: verbs: Avoid 1kb stack
Date: Tue, 08 Jan 2013 10:09:36 -0800 [thread overview]
Message-ID: <1357668576.12749.55.camel@joe-AO722> (raw)
In-Reply-To: <20130108144604.GB16343@fieldses.org>
On Tue, 2013-01-08 at 09:46 -0500, J. Bruce Fields wrote:
> On Mon, Jan 07, 2013 at 11:41:36AM -0800, Joe Perches wrote:
> > 16 * 64 is a bit much.
> > Use kmalloc_array instead.
>
> I thought there was some reason we didn't do this.
>
> Grepping up through the callers.... It looks like the result is
> xprt_rdma_send_request returns -EIO, and as far as I can tell that gets
> passed up to the application on the client. That doesn't sound right.
No worries, it was just a warning I noticed when I
did an allmodconfig compilation.
Perhaps a comment there might be appropriate instead.
next prev parent reply other threads:[~2013-01-08 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 19:41 [PATCH] sunrpc: verbs: Avoid 1kb stack Joe Perches
2013-01-08 14:46 ` J. Bruce Fields
2013-01-08 18:09 ` Joe Perches [this message]
2013-01-08 22:52 ` Tom Talpey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357668576.12749.55.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steved@redhat.com \
--cc=tom@ogc.us \
--cc=ttalpey@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).