From: Steve Dickson <steved@redhat.com>
To: Bruce Fields <bfields@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH] NFSD: Don't give out read delegations on exclusive creates
Date: Wed, 15 May 2013 14:51:49 -0400 [thread overview]
Message-ID: <1368643909-8059-1-git-send-email-steved@redhat.com> (raw)
When an exclusive create is done with the mode bits
set (aka open(testfile, O_CREAT | O_EXCL, 0777)) this
causes a OPEN op followed by a SETATTR op. When a
read delegation is given in the OPEN, it causes
the SETATTR to delay with EAGAIN until the
delegation is recalled.
This patch caused exclusive creates to give out
a write delegation (which turn into no delegation)
which allows the SETATTR seamlessly succeed.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
fs/nfsd/nfs4state.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 316ec84..6b45d0e 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -3035,8 +3035,16 @@ nfs4_open_delegation(struct net *net, struct svc_fh *fh,
goto out;
if (open->op_share_access & NFS4_SHARE_ACCESS_WRITE)
flag = NFS4_OPEN_DELEGATE_WRITE;
- else
- flag = NFS4_OPEN_DELEGATE_READ;
+ else {
+ switch(open->op_createmode) {
+ case NFS4_CREATE_EXCLUSIVE:
+ case NFS4_CREATE_EXCLUSIVE4_1:
+ flag = NFS4_OPEN_DELEGATE_WRITE;
+ break;
+ default:
+ flag = NFS4_OPEN_DELEGATE_READ;
+ }
+ }
break;
default:
goto out;
--
1.8.1.4
next reply other threads:[~2013-05-15 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 18:51 Steve Dickson [this message]
2013-05-21 18:43 ` [PATCH] NFSD: Don't give out read delegations on exclusive creates Steve Dickson
2013-05-21 18:52 ` J. Bruce Fields
2013-05-21 19:23 ` J. Bruce Fields
2013-05-21 20:25 ` J. Bruce Fields
2013-05-22 16:20 ` J. Bruce Fields
2013-05-21 20:26 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368643909-8059-1-git-send-email-steved@redhat.com \
--to=steved@redhat.com \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).