From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 6/6] NFSv4.1: Enable state protection
Date: Mon, 20 May 2013 21:10:46 +0000 [thread overview]
Message-ID: <1369084243.52168.1.camel@leira.trondhjem.org> (raw)
In-Reply-To: <20130520204009.GH14677@fieldses.org>
On Mon, 2013-05-20 at 16:40 -0400, J. Bruce Fields wrote:
> On Mon, May 20, 2013 at 01:17:07PM -0400, Trond Myklebust wrote:
> > Use the EXCHGID4_FLAG_BIND_PRINC_STATEID exchange_id flag to enable
> > stateid protection. This means that if we create a stateid using a
> > particular principal, then we must use the same principal if we
> > want to change that state.
>
> Note that knfsd ignores this--its EXCHANGE_ID will always return with
> the flag unset regardless of what the client requests. My understanding
> is that that's legal ("Whether a bit is set or cleared on the arguments'
> flags does not force the server to set or clear the same bit on the
> results' side.")
>
> (Definitely not opposed to implementing it, just haven't gotten around
> to it.)
Right, but the point here is that the server is allowed to set
EXCHGID4_FLAG_BIND_PRINC_STATEID without the client requesting it, so
the client is supposed to always be ready for that situation.
This patch series is therefore more about ensuring that the Linux client
is spec compliant.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
next prev parent reply other threads:[~2013-05-20 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 17:17 [PATCH 1/6] NFSv4.1: Ensure that layoutget is called using the layout credential Trond Myklebust
2013-05-20 17:17 ` [PATCH 2/6] NFSv4.1: Ensure that layoutreturn uses the correct credential Trond Myklebust
2013-05-20 17:17 ` [PATCH 3/6] NFSv4.1: Ensure that reclaim_complete uses the right credential Trond Myklebust
2013-05-20 17:17 ` [PATCH 4/6] NFSv4.1: Ensure that test_stateid and free_stateid use correct credentials Trond Myklebust
2013-05-20 17:17 ` [PATCH 5/6] NFSv4.1: Use layout credentials for get_deviceinfo calls Trond Myklebust
2013-05-20 17:17 ` [PATCH 6/6] NFSv4.1: Enable state protection Trond Myklebust
2013-05-20 20:40 ` J. Bruce Fields
2013-05-20 21:10 ` Myklebust, Trond [this message]
2013-05-20 21:25 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369084243.52168.1.camel@leira.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).