From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Eric Paris <eparis@parisplace.org>
Cc: Steve Dickson <SteveD@redhat.com>,
"David P. Quigley" <dpquigl@tycho.nsa.gov>,
Linux NFS list <linux-nfs@vger.kernel.org>,
"Linux FS devel list" <linux-fsdevel@vger.kernel.org>,
Linux Security List <linux-security-module@vger.kernel.org>,
SELinux List <selinux@tycho.nsa.gov>
Subject: Re: [PATCH 13/13] Kconfig: Add Kconfig entry for Labeled NFS V4 client
Date: Mon, 20 May 2013 21:12:56 +0000 [thread overview]
Message-ID: <1369084374.52168.3.camel@leira.trondhjem.org> (raw)
In-Reply-To: <CACLa4pta+uRLDgU=hriQLVseJvtA-FJDCRK-oYKmzVNiRs299Q@mail.gmail.com>
On Mon, 2013-05-20 at 16:57 -0400, Eric Paris wrote:
> On Thu, May 16, 2013 at 11:56 AM, Steve Dickson <SteveD@redhat.com> wrote:
> > From: Steve Dickson <steved@redhat.com>
> >
> > This patch adds the NFS_V4_SECURITY_LABEL entry which
> > enables security label support for the NFSv4 client
> >
> > Signed-off-by: Steve Dickson <steved@redhat.com>
> > ---
> > fs/nfs/Kconfig | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> > index 79c500e..771831d3 100644
> > --- a/fs/nfs/Kconfig
> > +++ b/fs/nfs/Kconfig
> > @@ -107,6 +107,7 @@ config NFS_V4_1
> > config NFS_V4_2
> > bool "NFS client support for NFSv4.2"
> > depends on NFS_V4_1
> > + select NFS_V4_SECURITY_LABEL
>
> So this will force it on...
>
> > help
> > This option enables support for minor version 1 of the NFSv4 protocol
> > in the kernel's NFS client.
> > @@ -140,6 +141,24 @@ config NFS_V4_1_IMPLEMENTATION_ID_DOMAIN
> > If the NFS client is unchanged from the upstream kernel, this
> > option should be set to the default "kernel.org".
> >
> > +config NFS_V4_SECURITY_LABEL
> > + bool "Provide Security Label support for NFSv4 client"
> > + depends on NFS_V4 && SECURITY
>
> Even if SECURITY is not set?
>
> Why are you forcing this on with a select? select is dangerous..
Eric is right. In any case, we already agreed that we don't need _both_
a NFSv4.2 and a NFSv4 security label switch.
Please just get rid of NFS_V4_SECURITY_LABEL.
--
Trond Myklebust
Linux NFS client maintainer
NetApp
Trond.Myklebust@netapp.com
www.netapp.com
next prev parent reply other threads:[~2013-05-20 21:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 15:56 Froe e71bf1d708e1294b3bae64d04f03228b3625f2a3 Mon Sep 17 00:00:00 2001 Steve Dickson
2013-05-16 15:56 ` [PATCH 01/13] Security: Add hook to calculate context based on a negative dentry Steve Dickson
2013-05-20 21:14 ` Eric Paris
2013-05-16 15:56 ` [PATCH 02/13] Security: Add Hook to test if the particular xattr is part of a MAC model Steve Dickson
2013-05-20 21:15 ` Eric Paris
2013-05-16 15:56 ` [PATCH 03/13] LSM: Add flags field to security_sb_set_mnt_opts for in kernel mount data Steve Dickson
2013-05-20 21:15 ` Eric Paris
2013-05-16 15:56 ` [PATCH 04/13] SELinux: Add new labeling type native labels Steve Dickson
2013-05-20 21:16 ` Eric Paris
2013-05-16 15:56 ` [PATCH 05/13] NFSv4.2: Added NFS v4.2 support to the NFS client Steve Dickson
2013-05-20 19:06 ` Myklebust, Trond
2013-05-30 20:51 ` Bryan Schumaker
2013-05-31 21:12 ` Steve Dickson
2013-05-16 15:56 ` [PATCH 06/13] NFSv4: Add label recommended attribute and NFSv4 flags Steve Dickson
2013-05-16 15:56 ` [PATCH 07/13] NFSv4: Introduce new label structure Steve Dickson
2013-05-20 19:12 ` Myklebust, Trond
2013-05-21 18:53 ` Steve Dickson
2013-05-21 18:55 ` Myklebust, Trond
2013-05-16 15:56 ` [PATCH 08/13] NFSv4: Extend fattr bitmaps to support all 3 words Steve Dickson
2013-05-16 15:56 ` [PATCH 09/13] NFS:Add labels to client function prototypes Steve Dickson
2013-05-20 19:24 ` Myklebust, Trond
2013-05-16 15:56 ` [PATCH 10/13] NFS: Add label lifecycle management Steve Dickson
2013-05-16 15:56 ` [PATCH 11/13] NFS: Client implementation of Labeled-NFS Steve Dickson
2013-05-20 19:33 ` Myklebust, Trond
2013-05-20 19:40 ` Myklebust, Trond
2013-05-16 15:56 ` [PATCH 12/13] NFS: Extend NFS xattr handlers to accept the security namespace Steve Dickson
2013-05-16 15:56 ` [PATCH 13/13] Kconfig: Add Kconfig entry for Labeled NFS V4 client Steve Dickson
2013-05-20 20:57 ` Eric Paris
2013-05-20 21:12 ` Myklebust, Trond [this message]
2013-05-20 21:14 ` Myklebust, Trond
-- strict thread matches above, loose matches on Subject: below --
2013-05-22 16:50 [PATCH 00/13] lnfs: 3.10-rc2 release Steve Dickson
2013-05-22 16:50 ` [PATCH 13/13] Kconfig: Add Kconfig entry for Labeled NFS V4 client Steve Dickson
2013-05-13 19:11 [PATCH 00/13] lnfs: linux-3.10-rc1 release Steve Dickson
2013-05-13 19:11 ` [PATCH 13/13] Kconfig: Add Kconfig entry for Labeled NFS V4 client Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369084374.52168.3.camel@leira.trondhjem.org \
--to=trond.myklebust@netapp.com \
--cc=SteveD@redhat.com \
--cc=dpquigl@tycho.nsa.gov \
--cc=eparis@parisplace.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).