linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	"J. Bruce Fields" <bfields@fieldses.org>
Subject: [PATCH 0/2] rpc_pipe: clean up how dentry operations get set in rpc_pipefs
Date: Mon, 24 Jun 2013 21:05:38 -0400	[thread overview]
Message-ID: <1372122340-28982-1-git-send-email-jlayton@redhat.com> (raw)

Recently, I proposed a patch on the linux-nfs list to silence a WARNING:

    [PATCH] rpc_pipefs: only set rpc_dentry_ops if d_op isn't already set

When reviewing that, Bruce (properly) pointed out that that patch sucked
since it just hacked around the warning and did nothing to improve the
code. This patchset is an attempt to correct that by making rpc_pipefs
use a consistent set of dentry_operations, and ensuring that they're set
on every dentry at d_alloc time.

Since Trond has already merged the earlier patch I sent into his
nfs-for-next branch, this is based on top of that.

Jeff Layton (2):
  rpc_pipe: export simple_dentry_operations and have rpc_pipefs use it
  rpc_pipe: set dentry operations at d_alloc time

 fs/libfs.c            |  9 +++++----
 include/linux/fs.h    |  1 +
 net/sunrpc/rpc_pipe.c | 24 +++++++++++++++---------
 3 files changed, 21 insertions(+), 13 deletions(-)

-- 
1.8.1.4


             reply	other threads:[~2013-06-25  1:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-25  1:05 Jeff Layton [this message]
2013-06-25  1:05 ` [PATCH 1/2] rpc_pipe: export simple_dentry_operations and have rpc_pipefs use it Jeff Layton
2013-06-25 15:36   ` Myklebust, Trond
2013-07-01 16:22     ` Jeff Layton
2013-07-02 15:29       ` Jeff Layton
2013-06-25  1:05 ` [PATCH 2/2] rpc_pipe: set dentry operations at d_alloc time Jeff Layton
2013-06-25 11:00   ` Jeff Layton
2013-07-02 17:00 ` [PATCH v2] " Jeff Layton
2013-07-14 14:00   ` Al Viro
2013-07-15 10:43     ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372122340-28982-1-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).