From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx12.netapp.com ([216.240.18.77]:44817 "EHLO mx12.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932748Ab3GVTI1 (ORCPT ); Mon, 22 Jul 2013 15:08:27 -0400 From: "Myklebust, Trond" To: Chuck Lever CC: "linux-nfs@vger.kernel.org" Subject: Re: [PATCH v1 04/19] NFS: Refactor nfs4_call_data_sequence() Date: Mon, 22 Jul 2013 19:08:26 +0000 Message-ID: <1374520105.7972.22.camel@leira.trondhjem.org> References: <20130712155303.1444.62697.stgit@seurat.1015granger.net> <20130712163202.1444.45080.stgit@seurat.1015granger.net> In-Reply-To: <20130712163202.1444.45080.stgit@seurat.1015granger.net> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-nfs-owner@vger.kernel.org List-ID: T24gRnJpLCAyMDEzLTA3LTEyIGF0IDEyOjMyIC0wNDAwLCBDaHVjayBMZXZlciB3cm90ZToNCj4g UHVsbCBtYWluIGxvZ2ljIG91dCBvZiBuZnM0X2NhbGxfZGF0YV9zZXF1ZW5jZSgpIHNvIGl0IGNh bg0KPiBldmVudHVhbGx5IGJlIHNoYXJlZCB3aXRoIHRoZSBORlN2NC4wIGNhbGxfc3luYyBwYXRo LiAgVGhlIG5ldw0KPiBoZWxwZXIgZnVuY3Rpb24gaXMgbGVmdCBiZWhpbmQgdGhlIE5GU3Y0LjEg Q09ORklHIHN3aXRjaCBmb3Igbm93IHRvDQo+IGtlZXAgY29tcGlsZXIgd2FybmluZyBub2lzZSBh dCBhIG1pbmltdW0uDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBDaHVjayBMZXZlciA8Y2h1Y2subGV2 ZXJAb3JhY2xlLmNvbT4NCj4gLS0tDQo+ICBmcy9uZnMvbmZzNHByb2MuYyB8ICAgMjggKysrKysr KysrKysrKysrKysrLS0tLS0tLS0tLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMo KyksIDEwIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2ZzL25mcy9uZnM0cHJvYy5j IGIvZnMvbmZzL25mczRwcm9jLmMNCj4gaW5kZXggMmY2ZjNiOS4uZTUyZDJiMyAxMDA2NDQNCj4g LS0tIGEvZnMvbmZzL25mczRwcm9jLmMNCj4gKysrIGIvZnMvbmZzL25mczRwcm9jLmMNCj4gQEAg LTM5Myw2ICszOTMsMjMgQEAgc3RhdGljIHZvaWQgcmVuZXdfbGVhc2UoY29uc3Qgc3RydWN0IG5m c19zZXJ2ZXIgKnNlcnZlciwgdW5zaWduZWQgbG9uZyB0aW1lc3RhbXANCj4gIA0KPiAgI2lmIGRl ZmluZWQoQ09ORklHX05GU19WNF8xKQ0KPiAgDQo+ICtzdGF0aWMgaW50IG5mczRfcnVuX3JwY190 YXNrKHN0cnVjdCBycGNfY2xudCAqY2xudCwNCj4gKwkJCSAgICAgc3RydWN0IHJwY19tZXNzYWdl ICptc2csDQo+ICsJCQkgICAgIHN0cnVjdCBycGNfdGFza19zZXR1cCAqdGFza19zZXR1cCkNCj4g K3sNCj4gKwlzdHJ1Y3QgcnBjX3Rhc2sgKnRhc2s7DQo+ICsJaW50IHJldDsNCj4gKw0KPiArCXRh c2sgPSBycGNfcnVuX3Rhc2sodGFza19zZXR1cCk7DQo+ICsJaWYgKElTX0VSUih0YXNrKSkNCj4g KwkJcmV0ID0gUFRSX0VSUih0YXNrKTsNCj4gKwllbHNlIHsNCj4gKwkJcmV0ID0gdGFzay0+dGtf c3RhdHVzOw0KPiArCQlycGNfcHV0X3Rhc2sodGFzayk7DQo+ICsJfQ0KPiArCXJldHVybiByZXQ7 DQo+ICt9DQoNClBsZWFzZSBkb24ndCBzcGxpdCB0aGlzIG91dC4gRXZlbnR1YWxseSwgc29tZW9u ZSBpcyBnb2luZyB0byBjYWxsIHRoaXMNCndpdGggdGhlIFJQQ19UQVNLX0FTWU5DIGZsYWcgc2V0 LCBhbmQgYWxsIGhlbGwgd2lsbCBicmVhayBsb29zZS4NCg0KPiArDQo+ICBzdGF0aWMgdm9pZCBu ZnM0MV9zZXF1ZW5jZV9mcmVlX3Nsb3Qoc3RydWN0IG5mczRfc2VxdWVuY2VfcmVzICpyZXMpDQo+ ICB7DQo+ICAJc3RydWN0IG5mczRfc2Vzc2lvbiAqc2Vzc2lvbjsNCj4gQEAgLTY3NCw4ICs2OTEs NiBAQCBzdGF0aWMgaW50IG5mczRfY2FsbF9zeW5jX3NlcXVlbmNlKHN0cnVjdCBycGNfY2xudCAq Y2xudCwNCj4gIAkJCQkgICBzdHJ1Y3QgbmZzNF9zZXF1ZW5jZV9hcmdzICphcmdzLA0KPiAgCQkJ CSAgIHN0cnVjdCBuZnM0X3NlcXVlbmNlX3JlcyAqcmVzKQ0KPiAgew0KPiAtCWludCByZXQ7DQo+ IC0Jc3RydWN0IHJwY190YXNrICp0YXNrOw0KPiAgCXN0cnVjdCBuZnM0MV9jYWxsX3N5bmNfZGF0 YSBkYXRhID0gew0KPiAgCQkuc2VxX3NlcnZlciA9IHNlcnZlciwNCj4gIAkJLnNlcV9hcmdzID0g YXJncywNCj4gQEAgLTY4OCwxNCArNzAzLDcgQEAgc3RhdGljIGludCBuZnM0X2NhbGxfc3luY19z ZXF1ZW5jZShzdHJ1Y3QgcnBjX2NsbnQgKmNsbnQsDQo+ICAJCS5jYWxsYmFja19kYXRhID0gJmRh dGENCj4gIAl9Ow0KPiAgDQo+IC0JdGFzayA9IHJwY19ydW5fdGFzaygmdGFza19zZXR1cCk7DQo+ IC0JaWYgKElTX0VSUih0YXNrKSkNCj4gLQkJcmV0ID0gUFRSX0VSUih0YXNrKTsNCj4gLQllbHNl IHsNCj4gLQkJcmV0ID0gdGFzay0+dGtfc3RhdHVzOw0KPiAtCQlycGNfcHV0X3Rhc2sodGFzayk7 DQo+IC0JfQ0KPiAtCXJldHVybiByZXQ7DQo+ICsJcmV0dXJuIG5mczRfcnVuX3JwY190YXNrKGNs bnQsIG1zZywgJnRhc2tfc2V0dXApOw0KPiAgfQ0KPiAgDQo+ICAjZWxzZQ0KPiANCj4gLS0NCj4g VG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJl IGxpbnV4LW5mcyIgaW4NCj4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2Vy Lmtlcm5lbC5vcmcNCj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVs Lm9yZy9tYWpvcmRvbW8taW5mby5odG1sDQoNCi0tIA0KVHJvbmQgTXlrbGVidXN0DQpMaW51eCBO RlMgY2xpZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9uZC5NeWtsZWJ1c3RAbmV0YXBwLmNv bQ0Kd3d3Lm5ldGFwcC5jb20NCg==