* [PATCH] st_destroy_session: remove invalid testcase
@ 2013-10-04 20:28 Tigran Mkrtchyan
2013-10-07 15:37 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Tigran Mkrtchyan @ 2013-10-04 20:28 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs, Tigran Mkrtchyan
we cant expect NFS4ERR_NOT_ONLY_OP if spec
enforces NFS4ERR_OP_NOT_IN_SESSION
Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
---
nfs4.1/server41tests/st_destroy_session.py | 3 ---
1 file changed, 3 deletions(-)
diff --git a/nfs4.1/server41tests/st_destroy_session.py b/nfs4.1/server41tests/st_destroy_session.py
index 1feb671..f4f0762 100644
--- a/nfs4.1/server41tests/st_destroy_session.py
+++ b/nfs4.1/server41tests/st_destroy_session.py
@@ -164,6 +164,3 @@ def testDestoryNotSoleOps(t, env):
sid = sess1.sessionid
res = c.c.compound([op.destroy_session(sess1.sessionid), op.putrootfh()])
check(res, NFS4ERR_NOT_ONLY_OP)
-
- res = c.c.compound([op.putrootfh(), op.destroy_session(sess1.sessionid)])
- check(res, NFS4ERR_NOT_ONLY_OP)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] st_destroy_session: remove invalid testcase
2013-10-04 20:28 [PATCH] st_destroy_session: remove invalid testcase Tigran Mkrtchyan
@ 2013-10-07 15:37 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2013-10-07 15:37 UTC (permalink / raw)
To: Tigran Mkrtchyan; +Cc: linux-nfs
On Fri, Oct 04, 2013 at 10:28:12PM +0200, Tigran Mkrtchyan wrote:
> we cant expect NFS4ERR_NOT_ONLY_OP if spec
> enforces NFS4ERR_OP_NOT_IN_SESSION
I guess we could just add that to the list of allowable error returns,
but... yeah, OK, let's just remove that test. Applied.
--b.
>
> Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
> ---
> nfs4.1/server41tests/st_destroy_session.py | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/nfs4.1/server41tests/st_destroy_session.py b/nfs4.1/server41tests/st_destroy_session.py
> index 1feb671..f4f0762 100644
> --- a/nfs4.1/server41tests/st_destroy_session.py
> +++ b/nfs4.1/server41tests/st_destroy_session.py
> @@ -164,6 +164,3 @@ def testDestoryNotSoleOps(t, env):
> sid = sess1.sessionid
> res = c.c.compound([op.destroy_session(sess1.sessionid), op.putrootfh()])
> check(res, NFS4ERR_NOT_ONLY_OP)
> -
> - res = c.c.compound([op.putrootfh(), op.destroy_session(sess1.sessionid)])
> - check(res, NFS4ERR_NOT_ONLY_OP)
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-07 15:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-04 20:28 [PATCH] st_destroy_session: remove invalid testcase Tigran Mkrtchyan
2013-10-07 15:37 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).