From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH 1/2] nfsmount.conf: Remove duplicate 'bg' and 'fg' from parsing string.
Date: Tue, 8 Oct 2013 17:30:24 -0400 [thread overview]
Message-ID: <1381267825-27457-1-git-send-email-steved@redhat.com> (raw)
When the 'Background' and/or 'Foreground' options are set
in multiple sections of the nfsmount.conf file, each instance
gets added to the parsing string. This patch makes the first
instance of either option override the any others.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
utils/mount/configfile.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/utils/mount/configfile.c b/utils/mount/configfile.c
index 68b9f93..6985ed9 100644
--- a/utils/mount/configfile.c
+++ b/utils/mount/configfile.c
@@ -164,6 +164,20 @@ add_entry(char *opt)
SLIST_INSERT_HEAD(&head, entry, entries);
}
/*
+ * Check the alias list to see if the given
+ * opt is a alias
+ */
+char *is_alias(char *opt)
+{
+ int i;
+
+ for (i=0; i < mnt_alias_sz; i++) {
+ if (strcasecmp(opt, mnt_alias_tab[i].alias) == 0)
+ return mnt_alias_tab[i].opt;
+ }
+ return NULL;
+}
+/*
* See if the given entry exists if the link list,
* if so return that entry
*/
@@ -171,10 +185,21 @@ inline static
char *lookup_entry(char *opt)
{
struct entry *entry;
+ char *alias = is_alias(opt);
SLIST_FOREACH(entry, &head, entries) {
if (strcasecmp(entry->opt, opt) == 0)
return opt;
+ if (alias && strcasecmp(entry->opt, alias) == 0)
+ return opt;
+ if (alias && strcasecmp(alias, "fg") == 0) {
+ if (strcasecmp(entry->opt, "bg") == 0)
+ return opt;
+ }
+ if (alias && strcasecmp(alias, "bg") == 0) {
+ if (strcasecmp(entry->opt, "fg") == 0)
+ return opt;
+ }
}
return NULL;
}
--
1.8.3.1
next reply other threads:[~2013-10-08 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 21:30 Steve Dickson [this message]
2013-10-08 21:30 ` [PATCH 2/2] nfsmount.conf: remove duplicate 'timeo' from the parsing string Steve Dickson
2013-10-21 14:04 ` Steve Dickson
2013-10-21 14:04 ` [PATCH 1/2] nfsmount.conf: Remove duplicate 'bg' and 'fg' from " Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381267825-27457-1-git-send-email-steved@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).