linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Weston Andros Adamson <dros@netapp.com>
To: <Trond.Myklebust@netapp.com>
Cc: <linux-nfs@vger.kernel.org>, Weston Andros Adamson <dros@netapp.com>
Subject: [PATCH 0/5] Clean up open CLAIM_PREVIOUS code path
Date: Mon, 21 Oct 2013 13:10:09 -0400	[thread overview]
Message-ID: <1382375414-5854-1-git-send-email-dros@netapp.com> (raw)

My original patch was to just fix the NULL dereference, but Trond noticed
some other problems in _nfs4_opendata_reclaim_to_nfs4_state, so I went ahead
and fixed them.

I separated this into multiple patches for increased bisectability and made
sure the NULL dereference patch was first so that stable@ / distros can choose
to just fix the crash if they wish. 

I went a bit further than the issues Trond raised with the last patch, but I
think it's good for consistency and catching reference counting bugs as errors
and not BUG()s.

 -dros

Weston Andros Adamson (5):
  NFSv4: fix NULL dereference in open recover
  NFSv4: don't fail on missing fattr in open recover
  NFSv4: clean up state ref counting in open recover
  NFSv4: don't reprocess cached open CLAIM_PREVIOUS
  NFSv4: clean up nfs4_state reference counting

 fs/nfs/nfs4proc.c  | 39 +++++++++++++++++++++++++--------------
 fs/nfs/nfs4state.c |  3 ++-
 2 files changed, 27 insertions(+), 15 deletions(-)

-- 
1.7.12.4 (Apple Git-37)


             reply	other threads:[~2013-10-21 17:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 17:10 Weston Andros Adamson [this message]
2013-10-21 17:10 ` [PATCH 1/5] NFSv4: fix NULL dereference in open recover Weston Andros Adamson
2013-10-25  6:08   ` William Dauchy
2013-10-21 17:10 ` [PATCH 2/5] NFSv4: don't fail on missing fattr " Weston Andros Adamson
2013-10-21 17:10 ` [PATCH 3/5] NFSv4: clean up state ref counting " Weston Andros Adamson
2013-10-28 21:06   ` Myklebust, Trond
2013-10-29 12:32     ` Weston Andros Adamson
2013-10-29 12:33       ` Weston Andros Adamson
2013-10-29 12:41         ` Myklebust, Trond
2013-10-29 13:12           ` Weston Andros Adamson
2013-10-21 17:10 ` [PATCH 4/5] NFSv4: don't reprocess cached open CLAIM_PREVIOUS Weston Andros Adamson
2013-10-28 21:08   ` Myklebust, Trond
2013-10-28 23:00     ` Weston Andros Adamson
2013-10-21 17:10 ` [PATCH 5/5] NFSv4: clean up nfs4_state reference counting Weston Andros Adamson
2013-10-28 18:45   ` Myklebust, Trond
2013-10-28 18:53     ` Weston Andros Adamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382375414-5854-1-git-send-email-dros@netapp.com \
    --to=dros@netapp.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).