linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] mountd: disabling turning off TCP listeners
@ 2013-10-22  8:19 Steve Dickson
  2013-10-22  8:19 ` [PATCH 1/3] mountd: Use protocol bit fields to turn protocols off Steve Dickson
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Steve Dickson @ 2013-10-22  8:19 UTC (permalink / raw)
  To: Linux NFS Mailing list

Recently it was pointed out to me that the [-n | --no-tcp] flags 
were broken in mountd. Sure enough they are and they broke 
when nfs-utils moved to using libtirpc, which was years ago.

Obviously nobody is using these flags since has not been 
notice until now, but it seemed to me it no longer makes 
any sense to have flags. We really want people to use TCP 
so why should there be a way to turn it off? It should be
the opposite... They should be able to turn off UDP listeners
not TCP... 

So this patch set does just that. It  deprecate the ability to 
disable TCP listeners and addd the ability to disable UDP listeners.

Steve Dickson (3):
  mountd: Use protocol bit fields to turn protocols off.
  mountd: Deprecate the ability to disable TCP listeners.
  mountd: Add the ability to disable UDP listeners.

 support/include/rpcmisc.h |  2 +-
 support/nfs/rpcmisc.c     | 19 ++++++++++++++-----
 support/nfs/svc_create.c  |  5 +++++
 utils/mountd/mountd.c     | 15 +++++++++++----
 utils/mountd/mountd.man   |  6 +++---
 5 files changed, 34 insertions(+), 13 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH 0/3] mountd: disabling turning off TCP listeners (v2)
@ 2013-10-24 18:17 Steve Dickson
  2013-10-24 18:17 ` [PATCH 1/3] mountd: Use protocol bit fields to turn protocols off Steve Dickson
  0 siblings, 1 reply; 8+ messages in thread
From: Steve Dickson @ 2013-10-24 18:17 UTC (permalink / raw)
  To: Linux NFS Mailing list

[ Here is the second try for these patches incorporating the code review..]

Recently it was pointed out to me that the [-n | --no-tcp] flags 
were broken in mountd. Sure enough they are and they broke 
when nfs-utils moved to using libtirpc, which was years ago.

Obviously nobody is using these flags since has not been 
notice until now, but it seemed to me it no longer makes 
any sense to have flags. We really want people to use TCP 
so why should there be a way to turn it off? It should be
the opposite... They should be able to turn off UDP listeners
not TCP... 


Steve Dickson (3):
  mountd: Use protocol bit fields to turn protocols off.
  mountd: Deprecate the ability to disable TCP listeners.
  mountd: Add the ability to disable UDP listeners.

 support/include/rpcmisc.h |  2 +-
 support/nfs/rpcmisc.c     | 19 ++++++++++++++-----
 support/nfs/svc_create.c  |  5 +++++
 utils/mountd/mountd.c     | 17 ++++++++++++-----
 utils/mountd/mountd.man   |  6 +++---
 5 files changed, 35 insertions(+), 14 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2013-10-24 18:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-22  8:19 [PATCH 0/3] mountd: disabling turning off TCP listeners Steve Dickson
2013-10-22  8:19 ` [PATCH 1/3] mountd: Use protocol bit fields to turn protocols off Steve Dickson
2013-10-22  8:19 ` [PATCH 2/3] mountd: Deprecate the ability to disable TCP listeners Steve Dickson
2013-10-22 11:39   ` Jim Rees
2013-10-23 13:59     ` Steve Dickson
2013-10-23 14:42       ` Jim Rees
2013-10-22  8:19 ` [PATCH 3/3] mountd: Add the ability to disable UDP listeners Steve Dickson
  -- strict thread matches above, loose matches on Subject: below --
2013-10-24 18:17 [PATCH 0/3] mountd: disabling turning off TCP listeners (v2) Steve Dickson
2013-10-24 18:17 ` [PATCH 1/3] mountd: Use protocol bit fields to turn protocols off Steve Dickson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).