From: Jeff Layton <jlayton@redhat.com>
To: trond.myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org, dpquigl@davequigley.com
Subject: [PATCH] nfs: set security label when revalidating inode
Date: Sat, 2 Nov 2013 06:57:18 -0400 [thread overview]
Message-ID: <1383389838-1858-1-git-send-email-jlayton@redhat.com> (raw)
Currently, we fetch the security label when revalidating an inode's
attributes, but don't apply it. This is in contrast to the readdir()
codepath where we do apply label changes.
Cc: Dave Quigley <dpquigl@davequigley.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
fs/nfs/inode.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 4bc7538..6ae6160 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -923,6 +923,8 @@ __nfs_revalidate_inode(struct nfs_server *server, struct inode *inode)
if (nfsi->cache_validity & NFS_INO_INVALID_ACL)
nfs_zap_acl_cache(inode);
+ nfs_setsecurity(inode, fattr, label);
+
dfprintk(PAGECACHE, "NFS: (%s/%Ld) revalidation complete\n",
inode->i_sb->s_id,
(long long)NFS_FILEID(inode));
--
1.8.3.1
next reply other threads:[~2013-11-02 10:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-02 10:57 Jeff Layton [this message]
2013-11-03 0:46 ` [PATCH] nfs: set security label when revalidating inode Dave Quigley
2013-11-03 2:23 ` Myklebust, Trond
2013-11-03 10:14 ` Jeff Layton
2013-11-03 11:01 ` Jeff Layton
[not found] ` <32FF43CF-D4D7-41AD-9B2F-8BAD6C2F846C@netapp.com>
2013-11-03 17:01 ` Jeff Layton
2013-11-03 18:41 ` Myklebust, Trond
2013-11-04 1:28 ` Jeff Layton
2013-11-04 15:19 ` Steve Dickson
2013-11-04 16:03 ` Myklebust, Trond
2013-11-04 17:56 ` Steve Dickson
2013-11-04 19:20 ` Labeled NFS: Is the value of FATTR4_WORD2_SECURITY_LABEL correct? Myklebust, Trond
2013-11-04 19:30 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383389838-1858-1-git-send-email-jlayton@redhat.com \
--to=jlayton@redhat.com \
--cc=dpquigl@davequigley.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).