linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: steved@redhat.com
Cc: bfields@fieldses.org, linux-nfs@vger.kernel.org
Subject: [PATCH 0/2] gssd: prevent race between gssd startup and fstab mounts
Date: Fri, 15 Nov 2013 14:15:29 -0500	[thread overview]
Message-ID: <1384542931-18753-1-git-send-email-jlayton@redhat.com> (raw)

I recently proposed a patchset that allows the kernel to figure out
if gssd is running in a more robust fashion than it has in the past.

While reviewing that, Bruce pointed out that that mechanism may cause
us to race with mounts that are happening at init time since the
parent process does not wait until the child is set up when daemonizing.

This patchset aims to correct that by switching gssd to use the
mydaemon() function that we use in other tools for a similar purpose.
Instead of cut and pasting that though like has been done in the past,
I've gone ahead and moved the function into libnfs.a and made the
existing users link that in at compile time.

Jeff Layton (2):
  nfs-utils: consolidate mydaemon() and release_parent() implementations
  gssd: don't let parent exit until child has a chance to scan directory
    once

 support/include/nfslib.h    |   4 ++
 support/nfs/Makefile.am     |   2 +-
 support/nfs/mydaemon.c      | 148 ++++++++++++++++++++++++++++++++++++++++++++
 utils/gssd/gssd.c           |   6 +-
 utils/gssd/gssd.h           |   1 +
 utils/gssd/gssd_main_loop.c |   4 ++
 utils/gssd/svcgssd.c        |  90 +--------------------------
 utils/idmapd/idmapd.c       |  82 +-----------------------
 8 files changed, 168 insertions(+), 169 deletions(-)
 create mode 100644 support/nfs/mydaemon.c

-- 
1.8.3.1


             reply	other threads:[~2013-11-15 19:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-15 19:15 Jeff Layton [this message]
2013-11-15 19:15 ` [PATCH 1/2] nfs-utils: consolidate mydaemon() and release_parent() implementations Jeff Layton
2013-11-20 21:24   ` Steve Dickson
2013-11-15 19:15 ` [PATCH 2/2] gssd: don't let parent exit until child has a chance to scan directory once Jeff Layton
2013-11-18 16:38   ` J. Bruce Fields
2013-11-18 16:48     ` Myklebust, Trond
2013-11-18 16:53       ` Jeff Layton
2013-11-20 21:24   ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384542931-18753-1-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).