linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Harshula Jayasuriya <harshula@redhat.com>
To: Steve Dickson <steved@redhat.com>, linux-nfs@vger.kernel.org
Cc: Jeff Layton <jlayton@redhat.com>,
	"J.Bruce Fields" <bfields@citi.umich.edu>,
	NeilBrown <neilb@suse.de>
Subject: [PATCH v2] exportfs: modify can_test() to use LONG_MAX when appropriate
Date: Mon, 18 Nov 2013 10:45:49 +1100	[thread overview]
Message-ID: <1384731949.14391.120.camel@serendib> (raw)
In-Reply-To: <1384511960.14391.115.camel@serendib>

This patch is the nfs-utils patch corresponding to the kernel patch
"sunrpc: prepare NFS for 2038": "The kernel sunrpc code needs to handle
seconds since epoch greater than 2147483647. This means functions that
parse time as an int need to handle it as time_t."

When appropriate exportfs should use LONG_MAX in can_test() instead of
INT_MAX.

kernel INT_MAX + exportfs INT_MAX: "Tue Jan 19 03:14:08 UTC 2038"
=================================================================

exportfs: /mnt/export does not support NFS export:
------------------------------------------------------------
 # cat /proc/net/rpc/auth.unix.ip/content
 #class IP domain
------------------------------------------------------------

+ mount fail:
------------------------------------------------------------
 # cat /proc/net/rpc/auth.unix.ip/content
 #class IP domain
 # expiry=2147483768 refcnt=2 flags=4
 # nfsd 192.168.1.6 -no-domain-
------------------------------------------------------------

kernel LONG_MAX + exportfs INT_MAX: "Tue Jan 19 03:14:08 UTC 2038"
==================================================================

"exportfs: /mnt/export does not support NFS export":
------------------------------------------------------------
 # cat /proc/net/rpc/auth.unix.ip/content
 #class IP domain
------------------------------------------------------------

+ mount success:
------------------------------------------------------------
 # cat /proc/net/rpc/auth.unix.ip/content
 #class IP domain
 # expiry=2147485448 refcnt=2 flags=1
 nfsd 192.168.1.6 *
------------------------------------------------------------

kernel LONG_MAX + exportfs LONG_MAX: "Tue Jan 19 03:14:08 UTC 2038"
===================================================================

exportfs:
------------------------------------------------------------
 # cat /proc/net/rpc/auth.unix.ip/content
 #class IP domain
 # expiry=9223372036854775807 refcnt=1 flags=1
 nfsd 0.0.0.0 -test-client-
------------------------------------------------------------

+ mount success:
------------------------------------------------------------
 # cat /proc/net/rpc/auth.unix.ip/content
 #class IP domain
 # expiry=2147485448 refcnt=2 flags=1
 nfsd 192.168.1.6 *
 # expiry=9223372036854775807 refcnt=1 flags=1
 nfsd 0.0.0.0 -test-client-
------------------------------------------------------------

Signed-off-by: Harshula Jayasuriya <harshula@redhat.com>
---
 utils/exportfs/exportfs.c | 27 +++++++++++++++++++++++----
 1 file changed, 23 insertions(+), 4 deletions(-)

diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index da5fe21..9f13858 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -27,6 +27,8 @@
 #include <netdb.h>
 #include <errno.h>
 #include <dirent.h>
+#include <limits.h>
+#include <time.h>
 
 #include "sockaddr.h"
 #include "misc.h"
@@ -406,17 +408,34 @@ unexportfs(char *arg, int verbose)
 
 static int can_test(void)
 {
+	char buf[1024];
 	int fd;
 	int n;
-	char *setup = "nfsd 0.0.0.0 2147483647 -test-client-\n";
+
 	fd = open("/proc/net/rpc/auth.unix.ip/channel", O_WRONLY);
-	if ( fd < 0) return 0;
-	n = write(fd, setup, strlen(setup));
+	if (fd < 0)
+		return 0;
+
+	/* We introduce tolerance of 1 day to ensure that we use a
+	 * LONG_MAX for the expiry timestamp before it is actually
+	 * needed. To use LONG_MAX, the kernel code must have commit
+	 * 2f74f972d4cc7d83408ea0c32d424edcb44887bf
+	 * (sunrpc: prepare NFS for 2038).
+	 */
+#define INT_TO_LONG_THRESHOLD_SECS (INT_MAX - (60 * 60 * 24))
+	if (time(NULL) > INT_TO_LONG_THRESHOLD_SECS)
+		sprintf(buf, "nfsd 0.0.0.0 %ld -test-client-\n", LONG_MAX);
+	else
+		sprintf(buf, "nfsd 0.0.0.0 %d -test-client-\n", INT_MAX);
+
+	n = write(fd, buf, strlen(buf));
 	close(fd);
 	if (n < 0)
 		return 0;
+
 	fd = open("/proc/net/rpc/nfsd.export/channel", O_WRONLY);
-	if ( fd < 0) return 0;
+	if (fd < 0)
+		return 0;
 	close(fd);
 	return 1;
 }
-- 
1.8.3.1


  reply	other threads:[~2013-11-17 23:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 17:46 [PATCH] sunrpc: prepare NFS for 2038 Harshula Jayasuriya
2013-08-15 17:52 ` J.Bruce Fields
2013-11-11  7:20   ` [PATCH] exportfs: modify can_test() to use LONG_MAX when appropriate Harshula Jayasuriya
2013-11-11  7:53     ` NeilBrown
2013-11-11 11:20       ` Harshula Jayasuriya
2013-11-15  6:15         ` Harshula Jayasuriya
2013-11-15  6:38           ` NeilBrown
2013-11-15 10:39             ` Harshula Jayasuriya
2013-11-17 23:45               ` Harshula Jayasuriya [this message]
2013-11-20 21:20                 ` [PATCH v2] " Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384731949.14391.120.camel@serendib \
    --to=harshula@redhat.com \
    --cc=bfields@citi.umich.edu \
    --cc=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).