linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: trond.myklebust@primarydata.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v2 0/5] nfs: consolidate rename code into one set of functions
Date: Mon, 17 Mar 2014 07:06:53 -0400	[thread overview]
Message-ID: <1395054418-14504-1-git-send-email-jlayton@redhat.com> (raw)

Summary of changes:

v2: remove -ERESTARTSYS error handling in nfs_rename
    hardcode isdir value in fsnotify_nameremove call for sillyrenames
     
As Trond pointed out recently, it makes little sense to maintain two
separate sets of functions for handling RENAMEs.

This patchset converts nfs_rename to use the asynchronous RENAME
infrastructure that is already in place for sillyrenames. It also
does some cleanup to remove some minor layering violations, and
adds a patch to make the sillyrename code emit a fsnotify_nameremove
when a sillyrename succeeds.

I've lightly tested this set and it seems to do the right thing,
but it obviously could stand some time in linux-next.

Jeff Layton (5):
  nfs: abstract out code needed to complete a sillyrename
  nfs: make nfs_async_rename non-static
  nfs: convert nfs_rename to use async_rename infrastructure
  nfs: remove synchronous rename code
  nfs: emit a fsnotify_nameremove call in sillyrename codepath

 fs/nfs/dir.c            | 13 +++++++++++--
 fs/nfs/internal.h       |  7 +++++++
 fs/nfs/nfs3proc.c       | 36 ------------------------------------
 fs/nfs/nfs4proc.c       | 44 --------------------------------------------
 fs/nfs/proc.c           | 25 -------------------------
 fs/nfs/unlink.c         | 35 ++++++++++++++++++++++++++++++-----
 include/linux/nfs_fs.h  |  1 -
 include/linux/nfs_xdr.h |  3 +--
 8 files changed, 49 insertions(+), 115 deletions(-)

-- 
1.8.5.3


             reply	other threads:[~2014-03-17 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17 11:06 Jeff Layton [this message]
2014-03-17 11:06 ` [PATCH v2 1/5] nfs: abstract out code needed to complete a sillyrename Jeff Layton
2014-03-17 11:06 ` [PATCH v2 2/5] nfs: make nfs_async_rename non-static Jeff Layton
2014-03-17 11:06 ` [PATCH v2 3/5] nfs: convert nfs_rename to use async_rename infrastructure Jeff Layton
2014-03-17 11:06 ` [PATCH v2 4/5] nfs: remove synchronous rename code Jeff Layton
2014-03-17 11:06 ` [PATCH v2 5/5] nfs: emit a fsnotify_nameremove call in sillyrename codepath Jeff Layton
2014-03-17 16:00 ` [PATCH v2 0/5] nfs: consolidate rename code into one set of functions Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395054418-14504-1-git-send-email-jlayton@redhat.com \
    --to=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).