linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fs: Use RCU_INIT_POINTER(x, NULL) in nfs/delegation.c
@ 2014-03-23 18:44 Monam Agarwal
  0 siblings, 0 replies; only message in thread
From: Monam Agarwal @ 2014-03-23 18:44 UTC (permalink / raw)
  To: trond.myklebust, linux-nfs, linux-kernel

This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)

The rcu_assign_pointer() ensures that the initialization of a structure       
is carried out before storing a pointer to that structure. 
And in the case of the NULL pointer, there is no structure to initialize. 
So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL)

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
---
 fs/nfs/delegation.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
index 5d8ccec..349e63b 100644
--- a/fs/nfs/delegation.c
+++ b/fs/nfs/delegation.c
@@ -249,7 +249,7 @@ nfs_detach_delegation_locked(struct nfs_inode *nfsi,
 	list_del_rcu(&delegation->super_list);
 	delegation->inode = NULL;
 	nfsi->delegation_state = 0;
-	rcu_assign_pointer(nfsi->delegation, NULL);
+	RCU_INIT_POINTER(nfsi->delegation, NULL);
 	spin_unlock(&delegation->lock);
 	return delegation;
 }
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-03-23 18:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-23 18:44 [PATCH] fs: Use RCU_INIT_POINTER(x, NULL) in nfs/delegation.c Monam Agarwal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).