linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Weston Andros Adamson <dros@primarydata.com>
To: trond.myklebust@primarydata.com
Cc: linux-nfs@vger.kernel.org, Weston Andros Adamson <dros@primarydata.com>
Subject: [PATCH 0/3] nfs: get rid of nfs_pgio_data, related cleanup
Date: Thu,  1 May 2014 15:14:50 -0400	[thread overview]
Message-ID: <1398971693-82399-1-git-send-email-dros@primarydata.com> (raw)

I'd like to know what people think of this proposed cleanup - it is to be
applied on top of the "pgio" branch at:

 git://git.linux-nfs.org/projects/dros/linux-nfs.git

The basic idea is that we no longer need a separate nfs_pgio_data structure,
because the nfs_pgio_header structure always has one - and only one.

I know this changes a lot of files, but I think now is the time to do this,
as we have to test everything anyways due to my subpage work and Anna's
pgio cleanup.

I should note that there is little chance we'll ever go back to having more
than one nfs_pgio_data per nfs_pgio_header - since the nfs_page subpage
splitting work allows us to describe arbitrary ranges at that level.

I think I can go a bit further by getting rid of the pgio_header refcnt.
I'll look closer at this soon...

 -dros

Weston Andros Adamson (3):
  nfs: move nfs_pgio_data and remove nfs_rw_header
  nfs: rename members of nfs_pgio_data
  nfs: merge nfs_pgio_data into _header

 fs/nfs/blocklayout/blocklayout.c |  99 +++++++++++----------
 fs/nfs/direct.c                  |   8 +-
 fs/nfs/internal.h                |  10 +--
 fs/nfs/nfs3proc.c                |  21 +++--
 fs/nfs/nfs4_fs.h                 |   6 +-
 fs/nfs/nfs4filelayout.c          | 169 +++++++++++++++++------------------
 fs/nfs/nfs4proc.c                | 105 +++++++++++-----------
 fs/nfs/nfs4trace.h               |  28 +++---
 fs/nfs/objlayout/objio_osd.c     |  24 +++--
 fs/nfs/objlayout/objlayout.c     |  81 ++++++++---------
 fs/nfs/objlayout/objlayout.h     |   8 +-
 fs/nfs/pageio.c                  | 186 ++++++++++++++++-----------------------
 fs/nfs/pnfs.c                    |  96 ++++++++------------
 fs/nfs/pnfs.h                    |  10 +--
 fs/nfs/proc.c                    |  27 +++---
 fs/nfs/read.c                    |  48 +++++-----
 fs/nfs/write.c                   |  65 +++++++-------
 include/linux/nfs_fs.h           |   2 +-
 include/linux/nfs_page.h         |  13 +--
 include/linux/nfs_xdr.h          |  31 +++----
 20 files changed, 489 insertions(+), 548 deletions(-)

-- 
1.8.5.2 (Apple Git-48)


             reply	other threads:[~2014-05-01 19:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-01 19:14 Weston Andros Adamson [this message]
2014-05-01 19:14 ` [PATCH 1/3] nfs: move nfs_pgio_data and remove nfs_rw_header Weston Andros Adamson
2014-05-01 19:14 ` [PATCH 2/3] nfs: rename members of nfs_pgio_data Weston Andros Adamson
2014-05-01 20:19   ` Trond Myklebust
2014-05-01 20:56     ` Weston Andros Adamson
2014-05-02 16:22       ` Weston Andros Adamson
2014-05-02 16:25         ` Weston Andros Adamson
2014-05-01 19:14 ` [PATCH 3/3] nfs: merge nfs_pgio_data into _header Weston Andros Adamson
2014-05-01 19:52 ` [PATCH 0/3] nfs: get rid of nfs_pgio_data, related cleanup Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398971693-82399-1-git-send-email-dros@primarydata.com \
    --to=dros@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).