From: Jeff Layton <jlayton@primarydata.com>
To: bfields@fieldses.org
Cc: trond.myklebust@primarydata.com, bhalevy@primarydata.com,
linux-nfs@vger.kernel.org
Subject: [PATCH 5/9] nfsd: remove unneeded zeroing of fields in nfsd4_proc_compound
Date: Fri, 30 May 2014 09:09:29 -0400 [thread overview]
Message-ID: <1401455373-18207-6-git-send-email-jlayton@primarydata.com> (raw)
In-Reply-To: <1401455373-18207-1-git-send-email-jlayton@primarydata.com>
The memset of resp in svc_process_common should ensure that these are
already zeroed by the time they get here.
Signed-off-by: Jeff Layton <jlayton@primarydata.com>
---
fs/nfsd/nfs4proc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index a1e16103a0bf..9e7846e19ea6 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -1292,11 +1292,8 @@ nfsd4_proc_compound(struct svc_rqst *rqstp,
xdr_reserve_space(&resp->xdr, 8 + args->taglen);
resp->taglen = args->taglen;
resp->tag = args->tag;
- resp->opcnt = 0;
resp->rqstp = rqstp;
cstate->minorversion = args->minorversion;
- cstate->replay_owner = NULL;
- cstate->session = NULL;
fh_init(current_fh, NFS4_FHSIZE);
fh_init(save_fh, NFS4_FHSIZE);
/*
--
1.9.3
next prev parent reply other threads:[~2014-05-30 13:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 13:09 [PATCH 0/9] nfsd: bugfixes and preliminary patches for client_mutex removal Jeff Layton
2014-05-30 13:09 ` [PATCH 1/9] nfsd: make nfsd4_encode_fattr static Jeff Layton
2014-05-30 13:09 ` [PATCH 2/9] nfsd: fix laundromat next-run-time calculation Jeff Layton
2014-05-30 13:09 ` [PATCH 3/9] nfsd4: use recall_lock for delegation hashing Jeff Layton
2014-05-30 13:09 ` [PATCH 4/9] nfsd: fix setting of NFS4_OO_CONFIRMED in nfsd4_open Jeff Layton
2014-05-30 13:09 ` Jeff Layton [this message]
2014-05-30 13:09 ` [PATCH 6/9] nfsd4: rename recall_lock to state_lock Jeff Layton
2014-05-30 13:09 ` [PATCH 7/9] nfsd4: hash deleg stateid only on successful nfs4_set_delegation Jeff Layton
2014-05-30 13:09 ` [PATCH 8/9] NFSd: Protect addition to the file_hashtbl Jeff Layton
2014-06-05 16:12 ` J. Bruce Fields
2014-06-05 16:18 ` Trond Myklebust
2014-06-05 16:27 ` Jeff Layton
2014-05-30 13:09 ` [PATCH 9/9] NFSd: protect delegation setup with the i_lock Jeff Layton
2014-06-02 8:46 ` Christoph Hellwig
2014-06-02 14:17 ` Jeff Layton
2014-06-02 18:20 ` Christoph Hellwig
2014-06-02 18:48 ` Jeff Layton
2014-05-30 13:13 ` [PATCH 10/9] nfsd: remove initial assignment of "p" in nfsd4_encode_security_label Jeff Layton
2014-06-04 19:56 ` [PATCH 0/9] nfsd: bugfixes and preliminary patches for client_mutex removal J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401455373-18207-6-git-send-email-jlayton@primarydata.com \
--to=jlayton@primarydata.com \
--cc=bfields@fieldses.org \
--cc=bhalevy@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).