* [PATCH] rpcbind: Remove a strict-aliasing warning
@ 2014-07-15 15:53 Steve Dickson
2014-08-18 15:03 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: Steve Dickson @ 2014-07-15 15:53 UTC (permalink / raw)
To: Linux NFS Mailing list
src/util.c: In function ‘in6_fillscopeid’:
src/util.c:106:3: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
ifindex = ntohs(*(u_int16_t *)&sin6->sin6_addr.s6_addr[2]);
^
src/util.c:109:4: warning: dereferencing type-punned pointer will break
strict-aliasing rules [-Wstrict-aliasing]
*(u_int16_t *)&sin6->sin6_addr.s6_addr[2] = 0;
Signed-off-by: Steve Dickson <steved@redhat.com>
---
src/util.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/util.c b/src/util.c
index 9a5fb69..7d56479 100644
--- a/src/util.c
+++ b/src/util.c
@@ -101,12 +101,14 @@ static void
in6_fillscopeid(struct sockaddr_in6 *sin6)
{
u_int16_t ifindex;
+ u_int16_t *addr;
if (IN6_IS_ADDR_LINKLOCAL(&sin6->sin6_addr)) {
- ifindex = ntohs(*(u_int16_t *)&sin6->sin6_addr.s6_addr[2]);
+ addr = (u_int16_t *)&sin6->sin6_addr.s6_addr[2];
+ ifindex = ntohs(*addr);
if (sin6->sin6_scope_id == 0 && ifindex != 0) {
sin6->sin6_scope_id = ifindex;
- *(u_int16_t *)&sin6->sin6_addr.s6_addr[2] = 0;
+ *addr = 0;
}
}
}
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rpcbind: Remove a strict-aliasing warning
2014-07-15 15:53 [PATCH] rpcbind: Remove a strict-aliasing warning Steve Dickson
@ 2014-08-18 15:03 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2014-08-18 15:03 UTC (permalink / raw)
To: Linux NFS Mailing list
On 07/15/2014 11:53 AM, Steve Dickson wrote:
> src/util.c: In function ‘in6_fillscopeid’:
> src/util.c:106:3: warning: dereferencing type-punned pointer will break
> strict-aliasing rules [-Wstrict-aliasing]
> ifindex = ntohs(*(u_int16_t *)&sin6->sin6_addr.s6_addr[2]);
> ^
>
> src/util.c:109:4: warning: dereferencing type-punned pointer will break
> strict-aliasing rules [-Wstrict-aliasing]
> *(u_int16_t *)&sin6->sin6_addr.s6_addr[2] = 0;
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed!
steved.
> ---
> src/util.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/util.c b/src/util.c
> index 9a5fb69..7d56479 100644
> --- a/src/util.c
> +++ b/src/util.c
> @@ -101,12 +101,14 @@ static void
> in6_fillscopeid(struct sockaddr_in6 *sin6)
> {
> u_int16_t ifindex;
> + u_int16_t *addr;
>
> if (IN6_IS_ADDR_LINKLOCAL(&sin6->sin6_addr)) {
> - ifindex = ntohs(*(u_int16_t *)&sin6->sin6_addr.s6_addr[2]);
> + addr = (u_int16_t *)&sin6->sin6_addr.s6_addr[2];
> + ifindex = ntohs(*addr);
> if (sin6->sin6_scope_id == 0 && ifindex != 0) {
> sin6->sin6_scope_id = ifindex;
> - *(u_int16_t *)&sin6->sin6_addr.s6_addr[2] = 0;
> + *addr = 0;
> }
> }
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-18 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-15 15:53 [PATCH] rpcbind: Remove a strict-aliasing warning Steve Dickson
2014-08-18 15:03 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).