From: Jeff Layton <jlayton@primarydata.com>
To: bfields@fieldses.org
Cc: hch@infradead.org, linux-nfs@vger.kernel.org
Subject: [PATCH v5 00/10] nfsd: more delegation fixes to prepare for client_mutex removal
Date: Mon, 21 Jul 2014 09:34:56 -0400 [thread overview]
Message-ID: <1405949706-27757-1-git-send-email-jlayton@primarydata.com> (raw)
v5:
- fix spinlocking in block_delegations. Lock should be held around all
of the set_bit calls so we don't race with the swap of the two
fields.
- eliminate destroy_revoked_delegation (just use nfs4_put_delegation)
- eliminate unneeded NULL pointer check in nfs4_setlease
v4:
- close more potential races in setlease code, and fix some bugs in
error handling in that code.
- clean up delegation setting functions, eliminating unused arguments
and avoiding allocations when there has already been a delegation
break
- add separate spinlock for block_delegations/delegation_blocked code
v3:
- use alternate method for checking for delegation break races after
getting a lease (just check fi_had_conflict instead)
- drop file_has_lease patch -- no longer needed
- move cl_revoked handling patch into this set. It means altering a
few of the later patches, but it keeps the set more topically
coherent
v2:
- move remove_stid call from nfs4_free_stid and into callers
Ok, I'm hoping we're now on the final respin here. This just cleans
up some nits that Christoph noticed in the last set. It also fixes
a potential bug that Neil noticed around the block_delegations
spinlocking.
Bruce, I noticed that you had merged the last set into your nfsd-next
branch, so let me know if you'd prefer me to do incremental changes
on top of that instead.
Jeff Layton (7):
nfsd: Protect the nfs4_file delegation fields using the fi_lock
nfsd: Fix delegation revocation
nfsd: ensure that clp->cl_revoked list is protected by clp->cl_lock
nfsd: drop unused stp arg to alloc_init_deleg
nfsd: clean up arguments to nfs4_open_delegation
nfsd: clean up nfs4_set_delegation
nfsd: give block_delegation and delegation_blocked its own spinlock
Trond Myklebust (3):
nfsd: Move the delegation reference counter into the struct nfs4_stid
nfsd: simplify stateid allocation and file handling
nfsd: Convert delegation counter to an atomic_long_t type
fs/nfsd/nfs4state.c | 253 ++++++++++++++++++++++++++++++++--------------------
fs/nfsd/state.h | 2 +-
2 files changed, 159 insertions(+), 96 deletions(-)
--
1.9.3
next reply other threads:[~2014-07-21 13:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-21 13:34 Jeff Layton [this message]
2014-07-21 13:34 ` [PATCH v5 01/10] nfsd: Protect the nfs4_file delegation fields using the fi_lock Jeff Layton
2014-07-21 15:51 ` Christoph Hellwig
2014-07-21 13:34 ` [PATCH v5 02/10] nfsd: Move the delegation reference counter into the struct nfs4_stid Jeff Layton
2014-07-21 13:34 ` [PATCH v5 03/10] nfsd: simplify stateid allocation and file handling Jeff Layton
2014-07-21 21:30 ` J. Bruce Fields
2014-07-21 22:42 ` Jeff Layton
2014-07-21 22:52 ` Trond Myklebust
2014-07-21 13:35 ` [PATCH v5 04/10] nfsd: Fix delegation revocation Jeff Layton
2014-07-21 13:35 ` [PATCH v5 05/10] nfsd: ensure that clp->cl_revoked list is protected by clp->cl_lock Jeff Layton
2014-07-21 15:52 ` Christoph Hellwig
2014-07-21 13:35 ` [PATCH v5 06/10] nfsd: Convert delegation counter to an atomic_long_t type Jeff Layton
2014-07-21 13:35 ` [PATCH v5 07/10] nfsd: drop unused stp arg to alloc_init_deleg Jeff Layton
2014-07-21 13:35 ` [PATCH v5 08/10] nfsd: clean up arguments to nfs4_open_delegation Jeff Layton
2014-07-21 13:35 ` [PATCH v5 09/10] nfsd: clean up nfs4_set_delegation Jeff Layton
2014-07-21 13:35 ` [PATCH v5 10/10] nfsd: give block_delegation and delegation_blocked its own spinlock Jeff Layton
2014-07-21 16:01 ` [PATCH v5 00/10] nfsd: more delegation fixes to prepare for client_mutex removal J. Bruce Fields
2014-07-21 17:54 ` J. Bruce Fields
2014-07-21 19:46 ` [PATCH v5 11/10] nfsd: set fl->fl_file properly in nfs4_setlease Jeff Layton
2014-07-21 19:54 ` Jeff Layton
2014-07-21 20:00 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405949706-27757-1-git-send-email-jlayton@primarydata.com \
--to=jlayton@primarydata.com \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).