From: Jeff Layton <jlayton@primarydata.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, hch@infradead.org
Subject: [PATCH v6 9/9] nfsd: remove dl_fh field from struct nfs4_delegation
Date: Fri, 25 Jul 2014 07:34:27 -0400 [thread overview]
Message-ID: <1406288067-20663-10-git-send-email-jlayton@primarydata.com> (raw)
In-Reply-To: <1406288067-20663-1-git-send-email-jlayton@primarydata.com>
Now that the nfs4_file has a filehandle in it, we no longer need to
keep a per-delegation copy of it. Switch to using the one in the
nfs4_file instead.
Signed-off-by: Jeff Layton <jlayton@primarydata.com>
---
fs/nfsd/nfs4callback.c | 2 +-
fs/nfsd/nfs4state.c | 3 +--
fs/nfsd/state.h | 1 -
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index c393d6ca3fce..e9813389687b 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -337,7 +337,7 @@ static void encode_cb_recall4args(struct xdr_stream *xdr,
p = xdr_reserve_space(xdr, 4);
*p++ = xdr_zero; /* truncate */
- encode_nfs_fh4(xdr, &dp->dl_fh);
+ encode_nfs_fh4(xdr, &dp->dl_file->fi_fhandle);
hdr->nops++;
}
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index ecfddca9b841..b0f83beeca75 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -604,7 +604,6 @@ alloc_init_deleg(struct nfs4_client *clp, struct svc_fh *current_fh)
INIT_LIST_HEAD(&dp->dl_perclnt);
INIT_LIST_HEAD(&dp->dl_recall_lru);
dp->dl_type = NFS4_OPEN_DELEGATE_READ;
- fh_copy_shallow(&dp->dl_fh, ¤t_fh->fh_handle);
INIT_WORK(&dp->dl_recall.cb_work, nfsd4_run_cb_recall);
return dp;
out_dec:
@@ -3097,7 +3096,7 @@ void nfsd4_prepare_cb_recall(struct nfs4_delegation *dp)
struct nfs4_client *clp = dp->dl_stid.sc_client;
struct nfsd_net *nn = net_generic(clp->net, nfsd_net_id);
- block_delegations(&dp->dl_fh);
+ block_delegations(&dp->dl_file->fi_fhandle);
/*
* We can't do this in nfsd_break_deleg_cb because it is
diff --git a/fs/nfsd/state.h b/fs/nfsd/state.h
index 0097d4771521..39747736e83b 100644
--- a/fs/nfsd/state.h
+++ b/fs/nfsd/state.h
@@ -96,7 +96,6 @@ struct nfs4_delegation {
u32 dl_type;
time_t dl_time;
/* For recall: */
- struct knfsd_fh dl_fh;
int dl_retries;
struct nfsd4_callback dl_recall;
};
--
1.9.3
next prev parent reply other threads:[~2014-07-25 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 11:34 [PATCH v6 0/9] nfsd: more delegation fixes to prepare for client_mutex removal Jeff Layton
2014-07-25 11:34 ` [PATCH v6 1/9] nfsd: simplify stateid allocation and file handling Jeff Layton
2014-07-25 11:34 ` [PATCH v6 2/9] nfsd: fully unhash delegations when revoking them Jeff Layton
2014-07-29 14:53 ` J. Bruce Fields
2014-07-29 16:41 ` Jeff Layton
2014-07-29 17:53 ` J. Bruce Fields
2014-07-25 11:34 ` [PATCH v6 3/9] nfsd: ensure that clp->cl_revoked list is protected by clp->cl_lock Jeff Layton
2014-07-25 11:34 ` [PATCH v6 4/9] nfsd: Convert delegation counter to an atomic_long_t type Jeff Layton
2014-07-25 11:34 ` [PATCH v6 5/9] nfsd: drop unused stp arg to alloc_init_deleg Jeff Layton
2014-07-25 11:34 ` [PATCH v6 6/9] nfsd: clean up arguments to nfs4_open_delegation Jeff Layton
2014-07-25 11:34 ` [PATCH v6 7/9] nfsd: clean up nfs4_set_delegation Jeff Layton
2014-07-25 11:34 ` [PATCH v6 8/9] nfsd: give block_delegation and delegation_blocked its own spinlock Jeff Layton
2014-07-25 11:34 ` Jeff Layton [this message]
2014-07-29 18:59 ` [PATCH v6 0/9] nfsd: more delegation fixes to prepare for client_mutex removal J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406288067-20663-10-git-send-email-jlayton@primarydata.com \
--to=jlayton@primarydata.com \
--cc=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).