linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Weston Andros Adamson <dros@primarydata.com>
To: trond.myklebust@primarydata.com
Cc: linux-nfs@vger.kernel.org, Weston Andros Adamson <dros@primarydata.com>
Subject: [PATCH 0/5] nfs_page_group_lock cleanup
Date: Fri,  8 Aug 2014 11:00:52 -0400	[thread overview]
Message-ID: <1407510057-6881-1-git-send-email-dros@primarydata.com> (raw)

These patches clean up some issues surrouding nfs_page_group_lock:

 - normalize wait/nonblock argument
 - make nonblocking calls really nonblocking
 - handle errors
 - ensure that we don't call blocking nfs_page_group_lock when holding the
   inode spinlock

This cleanup was inspired by Fengguang Wu's report that we were sleeping with
locks held in nfs_lock_and_join_requests.

Weston Andros Adamson (5):
  nfs: change nfs_page_group_lock argument
  nfs: fix nonblocking calls to nfs_page_group_lock
  nfs: use blocking page_group_lock in add_request
  nfs: fix error handling in lock_and_join_requests
  nfs: don't sleep with inode lock in lock_and_join_requests

 fs/nfs/pagelist.c        | 59 ++++++++++++++++++++++++++++++------------------
 fs/nfs/write.c           | 21 +++++++++++++----
 include/linux/nfs_page.h |  1 +
 3 files changed, 55 insertions(+), 26 deletions(-)

-- 
1.8.5.2 (Apple Git-48)


             reply	other threads:[~2014-08-08 15:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-08 15:00 Weston Andros Adamson [this message]
2014-08-08 15:00 ` [PATCH 1/5] nfs: change nfs_page_group_lock argument Weston Andros Adamson
2014-08-08 15:00 ` [PATCH 2/5] nfs: fix nonblocking calls to nfs_page_group_lock Weston Andros Adamson
2014-08-08 15:00 ` [PATCH 3/5] nfs: use blocking page_group_lock in add_request Weston Andros Adamson
2014-08-08 15:00 ` [PATCH 4/5] nfs: fix error handling in lock_and_join_requests Weston Andros Adamson
2014-08-08 15:00 ` [PATCH 5/5] nfs: don't sleep with inode lock " Weston Andros Adamson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1407510057-6881-1-git-send-email-dros@primarydata.com \
    --to=dros@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).