linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Weston Andros Adamson <dros@primarydata.com>
To: linux-nfs@vger.kernel.org
Cc: Weston Andros Adamson <dros@primarydata.com>
Subject: [PATCH 0/2] RFC: Fix nfs_generic_pgio page vector issues
Date: Thu, 14 Aug 2014 17:39:31 -0400	[thread overview]
Message-ID: <1408052373-4306-1-git-send-email-dros@primarydata.com> (raw)

This patchset fixes a few issues with the creation of nfs_pageio_descriptor
page vectors, which are passed to nfs_pgio_header structures.

These were first found by Toralf Förster <toralf.foerster@gmx.de> by running
trinity, but I've since received a report of a real world usecase that
hit a related issue: kvm with cache=none.

There are two problems that are closely related and seem to only be triggered
by direct i/o writev()/readv() calls.

The fixes are:
  - do not coalesce pages unless they are contiguous in file position *and*
    within / betwen pages.

  - do not allow duplicated pages in the pagevector


I'm still testing these, but I thought I'd share what I have with the list.

 -dros

Weston Andros Adamson (2):
  nfs: disallow duplicate pages in pgio page vectors
  nfs: can_coalesce_requests must enforce contiguity

 fs/nfs/pagelist.c | 30 +++++++++++++++++++++++++++---
 1 file changed, 27 insertions(+), 3 deletions(-)

-- 
1.8.5.2 (Apple Git-48)


             reply	other threads:[~2014-08-14 21:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 21:39 Weston Andros Adamson [this message]
2014-08-14 21:39 ` [PATCH 1/2] nfs: disallow duplicate pages in pgio page vectors Weston Andros Adamson
2014-08-14 21:39 ` [PATCH 2/2] nfs: can_coalesce_requests must enforce contiguity Weston Andros Adamson
2014-08-15 14:36 ` [PATCH 0/2] RFC: Fix nfs_generic_pgio page vector issues Weston Andros Adamson
2014-08-22 19:48   ` Toralf Förster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408052373-4306-1-git-send-email-dros@primarydata.com \
    --to=dros@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).