linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@primarydata.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, steved@redhat.com
Subject: [PATCH v3 0/8] nfsd: support for lifting grace period early
Date: Mon,  8 Sep 2014 10:46:41 -0400	[thread overview]
Message-ID: <1410187609-10319-1-git-send-email-jlayton@primarydata.com> (raw)

v3:
- only accept Y/y/1 in new procfile writes
- turn minorversion env var into a "reclaim complete" boolean
- serialize nfsdcltrack upcalls for a client
- reduce duplicate upcalls via NFSD4_CLIENT_STABLE flag
- don't allow reclaims after RECLAIM_COMPLETE

v2:
- move grace period handling into its own module

Here's a respin of the patches to reduce the grace period. A respun
version of the nfs-utils patches will be posted separately (needed due
to the minorversion to reclaim complete boolean change). I also threw
in some other patches that clean up the upcall handling a bit and
that prevent the client from being able to reclaim after sending a
RECLAIM_COMPLETE.

Original cover letter follows:

One of the huge annoyances in dealing with knfsd is the 90s grace period
that's imposed when the server reboots. This is not just an annoyance,
but means a siginificant amount of "downtime" in many production
environments.

This patchset aimed at reducing this pain. It adds a couple of /proc
knobs that tell the lockd and nfsd lock managers to lift the grace
period.

It also changes the UMH upcalls to pass a little bit of extra info in
the form of environment variables so that the upcall program can
determine whether there are still any clients that may be in the process
of reclaiming.

There are also a couple of cleanup patches in here that are not strictly
required. In particular, making a separate grace.ko module doesn't have
to be done, but I think it's a good idea.

Jeff Layton (8):
  lockd: move lockd's grace period handling into its own module
  nfsd: remove redundant boot_time parm from grace_done client tracking
    op
  lockd: add a /proc/fs/lockd/nlm_end_grace file
  nfsd: add a v4_end_grace file to /proc/fs/nfsd
  nfsd: pass extra info in env vars to upcalls to allow for early grace
    period end
  nfsd: serialize nfsdcltrack upcalls for a particular client
  nfsd: set and test NFSD4_CLIENT_STABLE bit to reduce nfsdcltrack
    upcalls
  nfsd: reject reclaim request when client has already sent
    RECLAIM_COMPLETE

 fs/Kconfig              |   6 +-
 fs/lockd/Makefile       |   3 +-
 fs/lockd/grace.c        |  65 ---------------------
 fs/lockd/netns.h        |   1 -
 fs/lockd/procfs.c       |  92 +++++++++++++++++++++++++++++
 fs/lockd/procfs.h       |  28 +++++++++
 fs/lockd/svc.c          |  10 +++-
 fs/nfs_common/Makefile  |   3 +-
 fs/nfs_common/grace.c   | 113 ++++++++++++++++++++++++++++++++++++
 fs/nfsd/Kconfig         |   1 +
 fs/nfsd/nfs4recover.c   | 150 +++++++++++++++++++++++++++++++++++++++++-------
 fs/nfsd/nfs4state.c     |  11 ++--
 fs/nfsd/nfsctl.c        |  45 +++++++++++++++
 fs/nfsd/state.h         |   6 +-
 include/linux/proc_fs.h |   2 +
 15 files changed, 440 insertions(+), 96 deletions(-)
 delete mode 100644 fs/lockd/grace.c
 create mode 100644 fs/lockd/procfs.c
 create mode 100644 fs/lockd/procfs.h
 create mode 100644 fs/nfs_common/grace.c

-- 
1.9.3


             reply	other threads:[~2014-09-08 14:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 14:46 Jeff Layton [this message]
2014-09-08 14:46 ` [PATCH v3 1/8] lockd: move lockd's grace period handling into its own module Jeff Layton
2014-09-08 14:46 ` [PATCH v3 2/8] nfsd: remove redundant boot_time parm from grace_done client tracking op Jeff Layton
2014-09-08 14:46 ` [PATCH v3 3/8] lockd: add a /proc/fs/lockd/nlm_end_grace file Jeff Layton
2014-09-08 14:46 ` [PATCH v3 4/8] nfsd: add a v4_end_grace file to /proc/fs/nfsd Jeff Layton
2014-09-09 12:21   ` Jeff Layton
2014-09-08 14:46 ` [PATCH v3 5/8] nfsd: pass extra info in env vars to upcalls to allow for early grace period end Jeff Layton
2014-09-08 14:46 ` [PATCH v3 6/8] nfsd: serialize nfsdcltrack upcalls for a particular client Jeff Layton
2014-09-08 14:46 ` [PATCH v3 7/8] nfsd: set and test NFSD4_CLIENT_STABLE bit to reduce nfsdcltrack upcalls Jeff Layton
2014-09-09 20:46   ` J. Bruce Fields
2014-09-09 20:56     ` Jeff Layton
2014-09-09 21:19       ` Jeff Layton
2014-09-08 14:46 ` [PATCH v3 8/8] nfsd: reject reclaim request when client has already sent RECLAIM_COMPLETE Jeff Layton
2014-09-10 13:22 ` [PATCH v3 9/8] nfsd: skip subsequent UMH "create" operations after the first one for v4.0 clients Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1410187609-10319-1-git-send-email-jlayton@primarydata.com \
    --to=jlayton@primarydata.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).