From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, miklos@szeredi.hu, raven@themaw.net,
viro@zeniv.linux.org.uk, jlayton@redhat.com, gregkh@suse.de,
linux-nfs@vger.kernel.org, leonardo.lists@gmail.com
Subject: Re: [PATCH 1/7] NFS4: Revert commit to make the automount code ignore LOOKUP_FOLLOW
Date: Fri, 23 Sep 2011 17:53:07 +0100 [thread overview]
Message-ID: <14116.1316796787@redhat.com> (raw)
In-Reply-To: <CA+55aFwt96i3k_UJREQU18xq=tRqRZGP8NhRJfbOaipqiVKnGQ@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > The problem with this is that this breaks nfs_follow_remote_path() used by
> > NFS4 to find the root object to mount for the mount() syscall.
>
> The above message is basically dishonest.
>
> That's not AT ALL the problem.
Dishonest? In what way am I lying about it? After I wrote that line I went
on to explain how to reproduce it and what was happening.
That was the problem addressed by that patch. I was including it as a means
to fix the NFS regression and as I pointed out in the cover note, it can be
actually be dropped if one of the further patches is introduced.
> That problem could have been fixed with a one-liner patch that already exists.
Which is fragile.
> This whole patch-series looks like just excuses for doing stupid things.
I believe you to be wrong.
Anyway, if I'm going to be accused of dishonesty, I see no further reason to
continuing in this discussion.
Have a good weekend.
David
next prev parent reply other threads:[~2011-09-23 16:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 16:24 [RFC][PATCH 0/7] Automount behaviour correction David Howells
2011-09-23 16:24 ` [PATCH 1/7] NFS4: Revert commit to make the automount code ignore LOOKUP_FOLLOW David Howells
2011-09-23 16:35 ` Linus Torvalds
2011-09-23 16:53 ` David Howells [this message]
2011-09-23 16:25 ` [PATCH 2/7] VFS: Make chown() and lchown() call fchownat() David Howells
2011-09-23 16:25 ` [PATCH 3/7] VFS: Change LOOKUP_NO_AUTOMOUNT to LOOKUP_AUTOMOUNT David Howells
2011-09-23 16:25 ` [PATCH 4/7] VFS: Move the automount suppression decision out to the initial callers of David Howells
2011-09-23 16:25 ` [PATCH 5/7] VFS: Ignore symlink following advice when pathwalking David Howells
2011-09-23 16:25 ` [PATCH 6/7] VFS: Make stat and xattr calls not automount David Howells
2011-09-23 16:26 ` [PATCH 7/7] VFS: Vary the automounting rules for autofs David Howells
2011-09-23 16:29 ` [RFC][PATCH 0/7] Automount behaviour correction Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14116.1316796787@redhat.com \
--to=dhowells@redhat.com \
--cc=gregkh@suse.de \
--cc=jlayton@redhat.com \
--cc=leonardo.lists@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=raven@themaw.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).