public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: linux-nfs@vger.kernel.org
Subject: blocklayout GETDEVICEINFO fix
Date: Fri, 26 Sep 2014 16:02:49 +0200	[thread overview]
Message-ID: <1411740170-18611-1-git-send-email-hch@lst.de> (raw)

The rpc_pipefs pattern used for the GETDEVICEINFO implementation in the
blocklayout driver is fundamentally not thread safe.  Workloads like
dbench manage to trigger concurrent GETDEVICEINFO calls though, so we
need to add a critical section around it.

I also wonder if we should avoid even sending multiple GETDEVICEINFO
a a higher level in the NFS client, as ѕending multiple request just
to cancel out their action before adding them to the cache doesn't
seem very helpful.


             reply	other threads:[~2014-09-26 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 14:02 Christoph Hellwig [this message]
2014-09-26 14:02 ` [PATCH] pnfs/blocklayout: serialize GETDEVICEINFO calls Christoph Hellwig
2014-09-26 14:29   ` Trond Myklebust
2014-09-26 15:48     ` Christoph Hellwig
2014-09-26 16:21       ` Trond Myklebust
2014-09-26 16:41         ` Christoph Hellwig
2014-10-24 14:29         ` Christoph Hellwig
2014-11-05  8:30           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411740170-18611-1-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox