Re: [PATCH] pnfs/blocklayout: serialize GETDEVICEINFO calls

Trond Myklebust
2014-09-26T14:29:34Z

On Fri, Sep 26, 2014 at 10:02 AM, Christoph Hellwig <hch@lst.de> wrote:
> The rpc_pipefs code isn't thread safe, leading to occasional use after
> frees when running xfstests generic/241 (dbench).
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/nfs/blocklayout/rpc_pipefs.c | 14 +++++++++-----
> fs/nfs/netns.h | 1 +
> 2 files changed, 10 insertions(+), 5 deletions(-)
>
>

It worries me that we're putting a mutex directly in the writeback
path. For small arrays, it might be acceptable, but what if you have a
block device with 1000s of disks on the back end?

Is there no better way to fix this issue?

--
Trond Myklebust

Linux NFS client maintainer, PrimaryData

trond.myklebust@primarydata.com