From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: [PATCH] exportfs: Do not fail on empty exports file.
Date: Mon, 17 Nov 2014 08:46:34 -0500 [thread overview]
Message-ID: <1416231994-5177-1-git-send-email-steved@redhat.com> (raw)
Commit 076dd80 introduced a regression that causes
exportfs to fail when there is an empty /etc/exports
file. A empty /etc/exports file is valid and should
not cause exportfs to fail.
Signed-off-by: Steve Dickson <steved@redhat.com>
---
support/export/export.c | 6 +++---
support/include/exportfs.h | 2 +-
utils/exportfs/exportfs.c | 10 +++++-----
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/support/export/export.c b/support/export/export.c
index ce714d4..376ca6d 100644
--- a/support/export/export.c
+++ b/support/export/export.c
@@ -71,7 +71,7 @@ static void warn_duplicated_exports(nfs_export *exp, struct exportent *eep)
*
*/
void
-export_read(char *fname)
+export_read(char *fname, int verbose)
{
struct exportent *eep;
nfs_export *exp;
@@ -90,8 +90,8 @@ export_read(char *fname)
warn_duplicated_exports(exp, eep);
}
endexportent();
- if (volumes == 0)
- xlog(L_ERROR, "No file systems exported!");
+ if (volumes == 0 && verbose)
+ xlog(L_WARNING, "No file systems exported!");
}
/**
diff --git a/support/include/exportfs.h b/support/include/exportfs.h
index 9021fae..3d89f12 100644
--- a/support/include/exportfs.h
+++ b/support/include/exportfs.h
@@ -133,7 +133,7 @@ struct addrinfo * client_resolve(const struct sockaddr *sap);
int client_member(const char *client,
const char *name);
-void export_read(char *fname);
+void export_read(char *fname, int verbose);
void export_reset(nfs_export *);
nfs_export * export_lookup(char *hname, char *path, int caconical);
nfs_export * export_find(const struct addrinfo *ai,
diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
index bdea12b..92fb9eb 100644
--- a/utils/exportfs/exportfs.c
+++ b/utils/exportfs/exportfs.c
@@ -47,7 +47,7 @@ static void error(nfs_export *exp, int err);
static void usage(const char *progname, int n);
static void validate_export(nfs_export *exp);
static int matchhostname(const char *hostname1, const char *hostname2);
-static void export_d_read(const char *dname);
+static void export_d_read(const char *dname, int verbose);
static void grab_lockfile(void);
static void release_lockfile(void);
@@ -182,8 +182,8 @@ main(int argc, char **argv)
atexit(release_lockfile);
if (f_export && ! f_ignore) {
- export_read(_PATH_EXPORTS);
- export_d_read(_PATH_EXPORTS_D);
+ export_read(_PATH_EXPORTS, f_verbose);
+ export_d_read(_PATH_EXPORTS_D, f_verbose);
}
if (f_export) {
if (f_all)
@@ -686,7 +686,7 @@ out:
/* Based on mnt_table_parse_dir() in
util-linux-ng/shlibs/mount/src/tab_parse.c */
static void
-export_d_read(const char *dname)
+export_d_read(const char *dname, int verbose)
{
int n = 0, i;
struct dirent **namelist = NULL;
@@ -729,7 +729,7 @@ export_d_read(const char *dname)
continue;
}
- export_read(fname);
+ export_read(fname, verbose);
}
for (i = 0; i < n; i++)
--
2.1.0
next reply other threads:[~2014-11-17 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 13:46 Steve Dickson [this message]
2014-11-17 18:32 ` [PATCH] exportfs: Do not fail on empty exports file Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416231994-5177-1-git-send-email-steved@redhat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox