From: Scott Mayhew <smayhew@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [nfs-utils PATCH v2 00/17] A few enhancements to mountstats.py
Date: Wed, 26 Nov 2014 14:13:38 -0500 [thread overview]
Message-ID: <1417029235-37675-1-git-send-email-smayhew@redhat.com> (raw)
Changes since v1:
- Changed the parsing to use the argparse module instead of optparse
- Added per-mountpoint headers to the output of 'mountstats --rpc'
- Revamped the ms-nfsstat command to take a variable list of mountpoints
(so now mountstats, ms-iostat, and ms-nfsstat all behave in the same
manner). Added -3 and -4 options which behave the same way they do in
nfsstat.c. The output doesn't still doesn't match up 100% with that
of nfsstat.c though (I'm just taking the first 12 characters of the
operation name and converting them to lowercase to use as labels, while
nfsstat.c defines its own labels, but also it looks to me like nfsstat.c
is missing some operations altoegether).
- Updated the man page for mountstats and added man pages for ms-iostat
and ms-nfsstat.
These are also available in the 'mountstats-improvements-v2' branch at
https://github.com/scottmayhew/nfs-utils.git
Original cover letter:
-------------------8<------------------
The following patches add a couple of enhancements to mountstats.py. I
also fixed a few bugs I encountered along the way. Highlights include:
- added support for -f/--file to allow stats to be parsed from an
aritrary input file instead of /proc/self/mountstats
- added support for -S/--since to show just the changes that have
occurred between the current and a previous set of statisics (works
with and without the -f option)
- added support for -R/--raw to generate 'raw' statistics (i.e. in the
same format as /proc/self/mountstats). It's intended to be used with
the -f and -S options.
- implemented the ms-nfsstat command to generate client-side
nfsstat-like statisics (only works with a single mountpoint)
My motivation for these changes was so that I could take various copies
of /proc/self/mountstats and massage them into data that I could feed
into the 'report' option of Dros's nfsometer tool for scenarios where
it's not feasible to run nfsometer itself (e.g. systems where we can't
start with an 'idle' state (i.e. no NFS filesystems initially
mounted), systems with multiple NFS filesystems mounted, and workloads
that can't easily be boiled down into an nfsometer workload file or run
via the custom workload environment variables).
Scott Mayhew (17):
mountstats: Fix up NFS event counters
mountstats: Add lists of various counters
mountstats: Refactor __parse_nfs_line and __parse_rpc_line
mountstats: Refactor compare_iostats
mountstats: Convert existing option parsing to use the argparse module
mountstats: Make ms-iostat output match that of nfs-iostat.py
mountstats: Make print_iostat_summary handle newly appearing mounts
mountstats: Add support for -f/--file to the mountstats and ms-iostat
commands
mountstats: Add support for -S/--since to the mountstats and ms-iostat
commands
mountstats: Fix IndexError in __parse_nfs_line
mountstats: Allow mountstats_command to take a variable number of
mountpoints
mountstats: Add support for -R/--raw to mountstats_command
mountstats: Implement nfsstat_command
mountstats: Updated the mountstats(8) man page.
mountstats: Added man page for ms-iostat(8)
mountstats: Added man page for ms-nfsstat(8)
mountstats: add ms-iostat and ms-nfsstat to Makefile.am
tools/mountstats/Makefile.am | 4 +-
tools/mountstats/mountstats.man | 45 +-
tools/mountstats/mountstats.py | 904 ++++++++++++++++++++++++++++------------
tools/mountstats/ms-iostat.man | 64 +++
tools/mountstats/ms-nfsstat.man | 49 +++
5 files changed, 777 insertions(+), 289 deletions(-)
create mode 100644 tools/mountstats/ms-iostat.man
create mode 100644 tools/mountstats/ms-nfsstat.man
--
1.9.3
next reply other threads:[~2014-11-26 19:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 19:13 Scott Mayhew [this message]
2014-11-26 19:13 ` [nfs-utils PATCH v2 01/17] mountstats: Fix up NFS event counters Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 02/17] mountstats: Add lists of various counters Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 03/17] mountstats: Refactor __parse_nfs_line and __parse_rpc_line Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 04/17] mountstats: Refactor compare_iostats Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 05/17] mountstats: Convert existing option parsing to use the argparse module Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 06/17] mountstats: Make ms-iostat output match that of nfs-iostat.py Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 07/17] mountstats: Make print_iostat_summary handle newly appearing mounts Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 08/17] mountstats: Add support for -f/--file to the mountstats and ms-iostat commands Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 09/17] mountstats: Add support for -S/--since " Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 10/17] mountstats: Fix IndexError in __parse_nfs_line Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 11/17] mountstats: Allow mountstats_command to take a variable number of mountpoints Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 12/17] mountstats: Add support for -R/--raw to mountstats_command Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 13/17] mountstats: Implement nfsstat_command Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 14/17] mountstats: Updated the mountstats(8) man page Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 15/17] mountstats: Added man page for ms-iostat(8) Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 16/17] mountstats: Added man page for ms-nfsstat(8) Scott Mayhew
2014-11-26 19:13 ` [nfs-utils PATCH v2 17/17] mountstats: add ms-iostat and ms-nfsstat to Makefile.am Scott Mayhew
2014-12-02 17:20 ` [nfs-utils PATCH v2 00/17] A few enhancements to mountstats.py Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417029235-37675-1-git-send-email-smayhew@redhat.com \
--to=smayhew@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox