Linux NFS development
 help / color / mirror / Atom feed
From: Scott Mayhew <smayhew@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [nfs-utils PATCH v3 01/17] mountstats: Fix up NFS event counters
Date: Mon,  8 Dec 2014 14:57:09 -0500	[thread overview]
Message-ID: <1418068645-10134-2-git-send-email-smayhew@redhat.com> (raw)
In-Reply-To: <1418068645-10134-1-git-send-email-smayhew@redhat.com>

The event counters in the mountstats program aren't in sync with the
event counters in the kernel.  Removed syncinodes and added
vfsupdatepage, vfssetattr, congestionwait, pnfsreads, and pnfswrites.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 tools/mountstats/mountstats.py | 33 ++++++++++++++++++---------------
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 247a64a..5fc93f4 100644
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -74,25 +74,29 @@ class DeviceData:
             self.__nfs_data['dentryrevalidates'] = int(words[2])
             self.__nfs_data['datainvalidates'] = int(words[3])
             self.__nfs_data['attrinvalidates'] = int(words[4])
-            self.__nfs_data['syncinodes'] = int(words[5])
-            self.__nfs_data['vfsopen'] = int(words[6])
-            self.__nfs_data['vfslookup'] = int(words[7])
-            self.__nfs_data['vfspermission'] = int(words[8])
+            self.__nfs_data['vfsopen'] = int(words[5])
+            self.__nfs_data['vfslookup'] = int(words[6])
+            self.__nfs_data['vfspermission'] = int(words[7])
+            self.__nfs_data['vfsupdatepage'] = int(words[8])
             self.__nfs_data['vfsreadpage'] = int(words[9])
             self.__nfs_data['vfsreadpages'] = int(words[10])
             self.__nfs_data['vfswritepage'] = int(words[11])
             self.__nfs_data['vfswritepages'] = int(words[12])
             self.__nfs_data['vfsreaddir'] = int(words[13])
-            self.__nfs_data['vfsflush'] = int(words[14])
-            self.__nfs_data['vfsfsync'] = int(words[15])
-            self.__nfs_data['vfslock'] = int(words[16])
-            self.__nfs_data['vfsrelease'] = int(words[17])
-            self.__nfs_data['setattrtrunc'] = int(words[18])
-            self.__nfs_data['extendwrite'] = int(words[19])
-            self.__nfs_data['sillyrenames'] = int(words[20])
-            self.__nfs_data['shortreads'] = int(words[21])
-            self.__nfs_data['shortwrites'] = int(words[22])
-            self.__nfs_data['delay'] = int(words[23])
+            self.__nfs_data['vfssetattr'] = int(words[14])
+            self.__nfs_data['vfsflush'] = int(words[15])
+            self.__nfs_data['vfsfsync'] = int(words[16])
+            self.__nfs_data['vfslock'] = int(words[17])
+            self.__nfs_data['vfsrelease'] = int(words[18])
+            self.__nfs_data['congestionwait'] = int(words[19])
+            self.__nfs_data['setattrtrunc'] = int(words[20])
+            self.__nfs_data['extendwrite'] = int(words[21])
+            self.__nfs_data['sillyrenames'] = int(words[22])
+            self.__nfs_data['shortreads'] = int(words[23])
+            self.__nfs_data['shortwrites'] = int(words[24])
+            self.__nfs_data['delay'] = int(words[25])
+            self.__nfs_data['pnfsreads'] = int(words[26])
+            self.__nfs_data['pnfswrites'] = int(words[27])
         elif words[0] == 'bytes:':
             self.__nfs_data['normalreadbytes'] = int(words[1])
             self.__nfs_data['normalwritebytes'] = int(words[2])
@@ -202,7 +206,6 @@ class DeviceData:
         print('Cache events:')
         print('  data cache invalidated %d times' % self.__nfs_data['datainvalidates'])
         print('  attribute cache invalidated %d times' % self.__nfs_data['attrinvalidates'])
-        print('  inodes synced %d times' % self.__nfs_data['syncinodes'])
         print()
         print('VFS calls:')
         print('  VFS requested %d inode revalidations' % self.__nfs_data['inoderevalidates'])
-- 
1.9.3


  reply	other threads:[~2014-12-08 20:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 19:57 [nfs-utils PATCH v3 00/17] A few enhancements to mountstats.py Scott Mayhew
2014-12-08 19:57 ` Scott Mayhew [this message]
2014-12-08 19:57 ` [nfs-utils PATCH v3 02/17] mountstats: Add lists of various counters Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 03/17] mountstats: Refactor __parse_nfs_line and __parse_rpc_line Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 04/17] mountstats: Refactor compare_iostats Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 05/17] mountstats: Convert existing option parsing to use the argparse module Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 06/17] mountstats: Make ms-iostat output match that of nfs-iostat.py Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 07/17] mountstats: Make print_iostat_summary handle newly appearing mounts Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 08/17] mountstats: Add support for -f/--file to the mountstats and ms-iostat commands Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 09/17] mountstats: Add support for -S/--since " Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 10/17] mountstats: Fix IndexError in __parse_nfs_line Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 11/17] mountstats: Allow mountstats_command to take a variable number of mountpoints Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 12/17] mountstats: Add support for -R/--raw to mountstats_command Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 13/17] mountstats: Implement nfsstat_command Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 14/17] mountstats: Updated the mountstats(8) man page Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 15/17] mountstats: Added man page for ms-iostat(8) Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 16/17] mountstats: Added man page for ms-nfsstat(8) Scott Mayhew
2014-12-08 19:57 ` [nfs-utils PATCH v3 17/17] mountstats: add ms-iostat and ms-nfsstat to Makefile.am Scott Mayhew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418068645-10134-2-git-send-email-smayhew@redhat.com \
    --to=smayhew@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox