From: <Anna.Schumaker@netapp.com>
To: <bfields@fieldses.org>
Cc: <linux-nfs@vger.kernel.org>
Subject: [PATCH 0/4] NFS: Add READ_PLUS support
Date: Wed, 17 Dec 2014 17:35:00 -0500 [thread overview]
Message-ID: <1418855704-14127-1-git-send-email-Anna.Schumaker@Netapp.com> (raw)
From: Anna Schumaker <Anna.Schumaker@Netapp.com>
These patches add server support for the NFS v4.2 operation READ_PLUS.
I noticed a race condition in the 3rd patch when I start needing vfs_llseek()
to determine if I should encode the next segment as either data or a hole. It
is possible that the file could change on us between each of the seek calls,
so we don't know if we are actually at a hole or data segment. I don't want to
add new locks to the NFS server for this case, so instead I've decided to
encode any "quantum data" segments as if they were actually data.
I tested these patches using xfstests, specificially generic/075, generic/091,
generic/112, generic/127, generic/210, and generic/263. Additionally, three
new tests are run once READ_PLUS support has been added: generic/213,
generic/214, and generic/228.
These patches and the corresponding client changes are available in the
[read_plus] branch of
git://git.linux-nfs.org/projects/anna/linux-nfs.git
Questions? Comments? Thoughts?
Anna
Anna Schumaker (4):
NFSD: nfsd4_encode_read() should encode eof and maxcount
NFSD: Add READ_PLUS support for data segments
NFSD: Add support for encoding holes in files
NFSD: Add support for encoding multiple segments
fs/nfsd/nfs4proc.c | 16 +++++
fs/nfsd/nfs4xdr.c | 174 +++++++++++++++++++++++++++++++++++++++++------------
2 files changed, 152 insertions(+), 38 deletions(-)
--
2.1.3
next reply other threads:[~2014-12-17 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 22:35 Anna.Schumaker [this message]
2014-12-17 22:35 ` [PATCH 1/4] NFSD: nfsd4_encode_read() should encode eof and maxcount Anna.Schumaker
2014-12-17 22:35 ` [PATCH 2/4] NFSD: Add READ_PLUS support for data segments Anna.Schumaker
2014-12-17 22:35 ` [PATCH 3/4] NFSD: Add support for encoding holes in files Anna.Schumaker
2014-12-17 22:35 ` [PATCH 4/4] NFSD: Add support for encoding multiple segments Anna.Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418855704-14127-1-git-send-email-Anna.Schumaker@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox