Linux NFS development
 help / color / mirror / Atom feed
From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: <steved@redhat.com>, <linux-nfs@vger.kernel.org>
Cc: <Anna.Schumaker@netapp.com>
Subject: [PATCH 0/2] Mountstats Fixes
Date: Wed, 8 Apr 2015 12:47:25 -0400	[thread overview]
Message-ID: <1428511647-14920-1-git-send-email-Anna.Schumaker@Netapp.com> (raw)

I had some trouble using mountstats to analyze READ_PLUS operations, so I
wrote these patches to fix my issues.

I found that /proc/self/mountstats was reporting "GETDEVICELIST" as "51",
most likely because it was removed from the client but the nfs4_procedures
array still has a placeholder for it.  Mountstats crashes when it tries to
analyze "51", so the second patch fixes this issue by looking for numeric
operation names.  I'm willing to put in stubs for GETDEVICELIST back into
the client if that would be a better fix.

Thanks,
Anna


Anna Schumaker (2):
  mountstats: Resync NFSv4 Operations List
  mountstats: Only count operations that have names

 tools/mountstats/mountstats.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

-- 
2.3.5


             reply	other threads:[~2015-04-08 16:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 16:47 Anna Schumaker [this message]
2015-04-08 16:47 ` [PATCH 1/2] mountstats: Resync NFSv4 Operations List Anna Schumaker
2015-04-08 17:57   ` Christoph Hellwig
2015-04-08 18:13     ` Anna Schumaker
2015-04-08 16:47 ` [PATCH 2/2] mountstats: Only count operations that have names Anna Schumaker
2015-04-08 17:01 ` [PATCH 0/2] Mountstats Fixes Trond Myklebust
2015-04-08 17:53   ` Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428511647-14920-1-git-send-email-Anna.Schumaker@Netapp.com \
    --to=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox