linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] SUNRPC: drop stale doc comments in xprtsock.c
@ 2015-05-06  8:32 Stefan Hajnoczi
  2015-06-04  8:44 ` Stefan Hajnoczi
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hajnoczi @ 2015-05-06  8:32 UTC (permalink / raw)
  To: linux-nfs
  Cc: Anna Schumaker, Trond Myklebust, J. Bruce Fields, Stefan Hajnoczi

Several functions have outdated arguments listed in the doc comments.
Drop documentation for arguments that no longer exist.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 net/sunrpc/xprtsock.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 66891e3..b142fee 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -900,9 +900,8 @@ static int xs_local_copy_to_xdr(struct xdr_buf *xdr, struct sk_buff *skb)
 
 /**
  * xs_local_data_ready - "data ready" callback for AF_LOCAL sockets
  * @sk: socket with data to read
- * @len: how much data to read
  *
  * Currently this assumes we can read the whole reply in a single gulp.
  */
 static void xs_local_data_ready(struct sock *sk)
@@ -964,9 +963,8 @@ static void xs_local_data_ready(struct sock *sk)
 
 /**
  * xs_udp_data_ready - "data ready" callback for UDP sockets
  * @sk: socket with data to read
- * @len: how much data to read
  *
  */
 static void xs_udp_data_ready(struct sock *sk)
 {
@@ -1388,9 +1386,8 @@ static int xs_tcp_data_recv(read_descriptor_t *rd_desc, struct sk_buff *skb, uns
 
 /**
  * xs_tcp_data_ready - "data ready" callback for TCP sockets
  * @sk: socket with data to read
- * @bytes: how much data to read
  *
  */
 static void xs_tcp_data_ready(struct sock *sk)
 {
@@ -1885,11 +1882,9 @@ static int xs_local_finish_connecting(struct rpc_xprt *xprt,
 }
 
 /**
  * xs_local_setup_socket - create AF_LOCAL socket, connect to a local endpoint
- * @xprt: RPC transport to connect
  * @transport: socket transport to connect
- * @create_sock: function to create a socket of the correct type
  */
 static int xs_local_setup_socket(struct sock_xprt *transport)
 {
 	struct rpc_xprt *xprt = &transport->xprt;
@@ -2124,11 +2119,8 @@ out:
 }
 
 /**
  * xs_tcp_setup_socket - create a TCP socket and connect to a remote endpoint
- * @xprt: RPC transport to connect
- * @transport: socket transport to connect
- * @create_sock: function to create a socket of the correct type
  *
  * Invoked by a work queue tasklet.
  */
 static void xs_tcp_setup_socket(struct work_struct *work)
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] SUNRPC: drop stale doc comments in xprtsock.c
  2015-05-06  8:32 [PATCH v2] SUNRPC: drop stale doc comments in xprtsock.c Stefan Hajnoczi
@ 2015-06-04  8:44 ` Stefan Hajnoczi
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2015-06-04  8:44 UTC (permalink / raw)
  To: linux-nfs; +Cc: Anna Schumaker, J. Bruce Fields, Trond Myklebust

[-- Attachment #1: Type: text/plain, Size: 6 bytes --]

Ping?

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-04  8:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-06  8:32 [PATCH v2] SUNRPC: drop stale doc comments in xprtsock.c Stefan Hajnoczi
2015-06-04  8:44 ` Stefan Hajnoczi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).